fix(code-index): refresh status routing on workspace-folder changes by tosinxt · Pull Request #1957 · Zoo-Code-Org/Zoo-Code

tosinxt · 2026-10-08T08:13:16Z

Related GitHub Issue

Closes: #1857

Description

CodeIndexStatusManager now also subscribes to vscode.workspace.onDidChangeWorkspaceFolders and routes it through the existing updateSubscription(), so a workspace-folder change that changes the selected workspace switches the progress subscription and publishes the new manager's status immediately, without waiting for an active-editor change.

No second workspace-selection algorithm: the folder event reuses updateSubscription(), whose "same manager" early return also prevents duplicate subscriptions and redundant publications when the selection doesn't change.
The new listener is stored and released with the existing cleanup pattern. dispose() releases it between the editor and progress subscriptions, and each cleanup is logged independently, so a failing cleanup doesn't stop the others; repeated disposal stays safe.
Changes stay within the two files from the scope guide; no changeset, per the guide.

Acceptance criteria → tests in code-index-status-manager.spec.ts:

Criterion	Test
Folder-only change switches A → B, disposes A's subscription, publishes B immediately; later B updates publish, stale A events are ignored	`switches to the newly selected workspace on a workspace-folder change alone`
Unchanged selection → no duplicate subscription or publication	`keeps the subscription when a workspace-folder change leaves the selection unchanged`
No workspace left → previous subscription released, stale events ignored	`releases the subscription when a workspace-folder change leaves no workspace`
Disposal releases the folder listener; repeated disposal is safe; a cleanup exception doesn't block other cleanup	`releases the workspace-folder listener on disposal even when its cleanup fails`
Existing tests still pass	all 12 existing cases unchanged

The local vscode mock gains workspace.onDidChangeWorkspaceFolders; the first test resolves the workspace through the real resolver by changing workspaceFolders, with no editor event.

Test Procedure

Run from src/:

pnpm exec vitest run services/code-index/__tests__/code-index-status-manager.spec.ts — before the fix the 4 new tests fail (no folder subscription exists); after it, 16/16 pass.
pnpm exec vitest run __tests__/extension.spec.ts services/code-index — 36 files, 848 tests pass.
pnpm exec vitest run (full suite) — 9,899 passed; the only failures are the 40 in __tests__/dist_assets.spec.ts, which check for build output in dist/ and fail identically on main without a build.
pnpm check-types ✅, pnpm lint ✅ (--max-warnings=0, eslint-suppressions.json unchanged), Prettier ✅.

Not run: the manual multi-root VS Code scenario from the issue. The regression is covered by the deterministic unit tests above.

Pre-Submission Checklist

Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
Scope: My changes are focused on the linked issue (one major feature/fix per PR).
Self-Review: I have performed a thorough self-review of my code.
Testing: New and/or updated tests have been added to cover my changes (if applicable).
Visual Snapshot (UI changes only): N/A, no UI change.
Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Visual Snapshots

N/A, no UI change.

Videos (interaction / animation only)

N/A.

Documentation Updates

No documentation updates are required.

Additional Notes

None.

Get in Touch

Discord: tosin.py

Status routing only refreshed on active-editor changes, so a workspace-folder change that switched the selected workspace left the UI subscribed to the previous manager until the editor changed. Closes Zoo-Code-Org#1857

coderabbitai · 2026-10-08T08:13:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: Zoo-Code-Org/Zoo-Code/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: b1809310-cf28-45db-9354-045aeb88df9a

📥 Commits

Reviewing files that changed from the base of the PR and between 2baac5e and 62c903c.

📒 Files selected for processing (2)

src/services/code-index/__tests__/code-index-status-manager.spec.ts
src/services/code-index/code-index-status-manager.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (5)

Check persistence and lifecycle invariants: awaited atomic writes, rollback or explicit partial-failure behavior, cross-window state consistency, stale listeners/watchers, cancellation, idempotency, and safe restart/resume without lost or d...