Repository navigation

feat(editor): route the diff-view save through the guard (U8, #1375) - #1916

Open

easonLiangWorldedtech wants to merge 74 commits into

Zoo-Code-Org:mainfrom

easonLiangWorldedtech:fws/u8-diffview-guarded-save

Commits on Oct 5, 2026
- split unit U1 of PR 1833 (issue 1375)
  easonLiangWorldedtech
  committed
  d5f8a79
- fix(file-safety): close the pre-merge findings on the publish primitive (U1, issue 1375)
  easonLiangWorldedtech
  committed
  aa0cdab
- fix(file-safety): propagate a non-ENOENT lstat failure in resolvePublishTarget (U1, issue 1375)
  easonLiangWorldedtech
  committed
  c4120b0
- fix(file-safety): keep the rollback pair typed and the mock stand-ins type-sound
  easonLiangWorldedtech
  committed
  97b599d
- rebuild unit u2 on the fixed chain
  easonLiangWorldedtech
  committed
  435be8b
- chore(lint): prune the safeWriteJson suppression this unit earns
  easonLiangWorldedtech
  committed
  625a976
- rebuild unit u3 on the fixed chain
  easonLiangWorldedtech
  committed
  4e2de13
- fix(task): declare the observation registry on Task in this unit
  easonLiangWorldedtech
  committed
  60376ca
- rebuild unit u4 on the fixed chain
  easonLiangWorldedtech
  committed
  77eb0a4
- chore(lint): prune the readFileTool.spec suppression this unit earns
  easonLiangWorldedtech
  committed
  d7eab3d
- rebuild unit u5 on the fixed chain
  easonLiangWorldedtech
  committed
  ca636d6
- rebuild unit U8 on U5 (corrected merge order)
  easonLiangWorldedtech
  committed
  45b7912
- chore(ci): rerun the e2e-mock lane
  easonLiangWorldedtech
  committed
  272171b
- fix(file-safety): inherit unit 1 committed guard
  easonLiangWorldedtech
  committed
  0576435
- test: rerun mocked e2e - no source change, previous run failed in the runner
  easonLiangWorldedtech
  committed
  09ff089
- fix(file-safety): keep the publish error message in RollbackFailureError
  easonLiangWorldedtech
  committed
  7d100e3
- test(file-safety): assert the exact staging directory removed after a rollback failure
  easonLiangWorldedtech
  committed
  dee0ae5
- test: re-trigger required checks - the queued runs were cancelled by the Actions queue, no source change
  easonLiangWorldedtech
  committed
  f2ba274
- test: re-run mocked e2e and the ubuntu lane - no source change since the last green run on these files
  easonLiangWorldedtech
  committed
  2847056
- test: re-run mocked e2e - the suite passed on the previous head of this branch and no source changed
  easonLiangWorldedtech
  committed
  d0dd137
- fix(file-safety): give the Windows DACL dump a per-write name
  easonLiangWorldedtech
  committed
  a9943a9
- test: third mocked-e2e attempt on this unit - the suite is green on the other eight units of the same chain with the same guard behaviour
  easonLiangWorldedtech
  committed
  8dc0d81
Commits on Oct 6, 2026
- chore(ci): re-run mocked E2E (apply_diff timeouts on the previous run; this unit was green on the earlier run)
  easonLiangWorldedtech
  committed
  4731627
- chore(ci): second re-run of the mocked E2E suite. The apply_diff fixtures 404 on this run while the identical content passes on #1918, so the failure is in the mock fixture matching, not this unit'…
  easonLiangWorldedtech
  committed
  6a289d7
- fix(tools): apply_diff must publish with edit-guard semantics, not create semantics
  easonLiangWorldedtech
  committed
  f94017f
Commits on Oct 7, 2026
- fix(file-safety): durable-copy publish and confined writes for the diff-view unit
  easonLiangWorldedtech
  committed
  be4ee70
- fix(file-safety): do not read a failed target lstat as a missing target
  easonLiangWorldedtech
  committed
  95c3b95
- fix(file-safety): compare staging and target identity with bigint stats
  easonLiangWorldedtech
  committed
  eefb2d1
- test(file-safety): pin the bigint options in the staging-identity tests
  easonLiangWorldedtech
  committed
  73ebb0d
- fix(file-safety): report a Windows replacement whose DACL was not preserved
  easonLiangWorldedtech
  committed
  73e6bba
- fix(diff-view): undo a partial open() instead of leaving an unapproved file
  easonLiangWorldedtech
  committed
  acded64
- fix(file-safety): route the DACL restore failure through onWarning too
  easonLiangWorldedtech
  committed
  954de79
- fix(file-safety): keep DACL warning delivery from failing the save
  easonLiangWorldedtech
  committed
  4ee44fb
- fix(utils): check confinement before taking the advisory lock
  easonLiangWorldedtech
  committed
  eb33473
- fix(integrations): the preview observation must not authorize an approved edit
  easonLiangWorldedtech
  committed
  9cb15d0
- fix(file-safety): handle async warning sinks and confine before mkdir
  easonLiangWorldedtech
  committed
  2fff927
- fix(tools): ApplyDiffTool must observe the version its diff was built on
  easonLiangWorldedtech
  committed
  1b8187f
- test(tools): type the apply_diff observation doubles for check-types
  easonLiangWorldedtech
  committed
  52f5dc2
- fix(integrations): never adopt an autosaved match for an unauthorized edit
  easonLiangWorldedtech
  committed
  c994d08
- fix(tools): never refresh a model observation the tool read on a different version
  easonLiangWorldedtech
  committed
  6f12ae4
Commits on Oct 8, 2026
- fix(editor): attribute an adopted publish to the version the preview saw
  easonLiangWorldedtech
  committed
  8b4d25b
- fix(u8): track placeholder ownership apart from the observation token
  easonLiangWorldedtech
  committed
  571dfbe
- fix(file-safety): one lock key whether the parent directory exists yet
  easonLiangWorldedtech
  committed
  a515758
- test(file-safety): a backup copy that fails part-way must not survive the write
  easonLiangWorldedtech
  committed
  01ad9b6
- fix(diff-view): put the save's post-publish cleanup inside the same teardown as a cancellation
  easonLiangWorldedtech
  committed
  6a4f511
Commits on Oct 9, 2026
- fix(diff-view): let only the teardown that started a pass finalize the session
  easonLiangWorldedtech
  committed
  0fbdf49
- test(file-safety): pin that an uncanonicalizable confined scope stops the write before the lock
  easonLiangWorldedtech
  committed
  2521ad9
- fix(diff-view): restore preview tabs for the pass that owns a rejected save, and pin the scope walk
  easonLiangWorldedtech
  committed
  308178a
- test(apply-diff): cover the two bracketing stats that can fail on their own
  easonLiangWorldedtech
  committed
  452a8e4
- fix(read-file): stop indenting the read content inside the notice templates
  easonLiangWorldedtech
  committed
  b73cec8
- test(safe-write): a warning sink that throws must not fail the committed write
  easonLiangWorldedtech
  committed
  d8e7015
- fix(diff-view): finalize the session when a cancellation lands during a teardown it does not own
  easonLiangWorldedtech
  committed
  0974ad5
- test(diff-view): put the rejected-publish comment back above the test it documents
  easonLiangWorldedtech
  committed
  318f011
- fix(file-safety): never abandon the backup seed descriptor when its close fails
  easonLiangWorldedtech
  committed
  8757698
- fix(diff-view): one caller owns the session's finalization, by claim rather than by reading state
  easonLiangWorldedtech
  committed
  226555d
- fix(safe-write): a write that declares no scope replaces the link instead of writing through it
  easonLiangWorldedtech
  committed
  6f64792
- Merge fork main (a101c613e) into fws/u8-diffview-guarded-save
  easonLiangWorldedtech
  committed
  73eac8a
- fix(diff-view): the rejected-save pass owns the session through preview restoration
  easonLiangWorldedtech
  committed
  0cd2537
- fix(safe-write): an existing Windows target is not published over under an unknown or unverifiable ACL
  easonLiangWorldedtech
  committed
  04dceaf
- fix(test): teach main's unicode-reader spec about hasClippedLines
  easonLiangWorldedtech
  committed
  d4a537f
- fix(safe-write): every descriptor this call owns is released through the retry-and-report path
  easonLiangWorldedtech
  committed
  5b3768e
- fix(safe-write): a failed Windows ACL step never publishes content, and a close is never attempted twice
  easonLiangWorldedtech
  committed
  6329f3b
Commits on Oct 10, 2026
- fix(safe-write-json): an unscoped write locks and reads the file it actually replaces
  easonLiangWorldedtech
  committed
  5ad9dde
- fix(safe-write): match a verified ACE against the whole principal, not its account name
  easonLiangWorldedtech
  committed
  aa886ff
- fix(diffview): put the finalization guard on the public reset(), not behind it
  easonLiangWorldedtech
  committed
  88d654a
- fix(safe-write-json): keep the referent lock beside the link-path lock on an unscoped publish
  easonLiangWorldedtech
  committed
  84dd3a7
- style: format the ten files the formatting gate flags on this PR
  easonLiangWorldedtech
  committed
  2d6c620
- test: scope the icacls assertion to the platform that issues the command
  easonLiangWorldedtech
  committed
  5e99a1a
- fix: fold a lock key from the deepest existing ancestor, not the way strings compare
  easonLiangWorldedtech
  committed
  19aec00
- fix(safe-write-json): take the lock on the canonical spelling of the link path
  easonLiangWorldedtech
  committed
  8836103
- style: reflow the lock-key spec to the repo's prettier output
  easonLiangWorldedtech
  committed
  f08604e
- fix(u8): refuse adoption when the rejection was about completeness, and fix the ACL read-back parser
  easonLiangWorldedtech
  committed
  689d8d0
Commits on Oct 11, 2026
- fix(editor): reconcile the observation when a guarded publish lands without durability
  easonLiangWorldedtech
  committed
  d15c849
- fix(utils): decide confinement once and reject a declared-empty root
  easonLiangWorldedtech
  committed
  41c97d8

Commits

Commits on Oct 5, 2026

Commits on Oct 6, 2026

Commits on Oct 7, 2026

Commits on Oct 8, 2026

Commits on Oct 9, 2026

Commits on Oct 10, 2026

Commits on Oct 11, 2026