Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Zoo-Code-Org/Zoo-Code/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (6)Treat model, provider, MCP, path, command, and tool data as untrusted.⚙️ CodeRabbit configuration file Files:
For persisted settings, verify the complete schema/storage/runtime/webview round trip, shared default semantics, and focused true plus false/unset tests.⚙️ CodeRabbit configuration file Files:
Require regression coverage at the lowest valid harness with behavior-focused assertions, including relevant negative, error, false/unset, and boundary cases.⚙️ CodeRabbit configuration file Files:
Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.⚙️ CodeRabbit configuration file Files:
Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
🔇 Additional comments (2)
📝 SummarySummary by CodeRabbit
WalkthroughClaude Opus 5.5 metadata and Anthropic provider tests now reflect its declared 128,000-token output limit. The tests also check that the model does not expose reasoning-budget support. ChangesClaude Opus 5.5 output limit
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Claude Opus 5.5’s direct Anthropic request is expected to retain its declared 128,000-token limit with adaptive thinking. The supplied changes and regression test reveal no actionable merge-blocking risk. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change raises the per-request output allowance on an existing provider path without evident new access or authority. The larger allowance could increase resource use, while the surrounding access and spending controls were not fully evidenced. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Regression EvidenceExplanation The explicit disabled branch lacks focused coverage. The change removes Resolution Add an Anthropic handler regression test for
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Awaiting fresh human maintainer or CODEOWNER approval. Automated review is complete for the latest commit but does not replace human approval. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Related GitHub Issue
Closes: #1853
Description
Claude Opus 5.5's direct Anthropic model entry declares a 128K output limit and uses adaptive thinking, but it also declares
supportsReasoningBudget: true. The output-limit resolver interprets that capability as legacy hybrid-budget handling, so Zoo Code replaces the declared model limit with 16,384 tokens when reasoning is enabled and 8,192 otherwise.For Opus 5.5,
supportsReasoningBinaryalready controls adaptive-thinking request construction. This PR removes only the incorrectsupportsReasoningBudgetcapability and updates its stale output-limit comment. The existingmaxTokens: 128_000value then becomes the effective request limit.Regression coverage verifies that:
{ type: "adaptive" }when reasoning is enabled;temperatureremains omitted;128000;supportsReasoningBudgetis absent from the resolved model info.The change is limited to Claude Opus 5.5 on the direct Anthropic provider path.
Test Procedure
Run the focused Anthropic provider suite:
pnpm --dir src exec vitest run api/providers/__tests__/anthropic.spec.tsRun affected typechecks:
Run lint for the changed source and test files.
Verify the Opus 5.5 request-shape regression:
thinkingremains{ type: "adaptive" }temperatureremains omittedmax_tokensis128000getModel().info.supportsReasoningBudgetis absentOptional manual verification: run a complex Opus 5.5 agent task that previously exhausted 16K tokens during thinking and confirm it progresses to text or tool use.
Pre-Submission Checklist
Visual Snapshots
N/A. This changes provider metadata and request construction only.
Videos (interaction / animation only)
N/A.
Documentation Updates