Repository navigation
fix(condense): summarize effective history, excluding truncated messages - #1841
PierrunoYT wants to merge 1 commit into
Conversation
summarizeConversation selected its input with getMessagesSinceLastSummary, which ignores truncationParent. Messages already hidden by sliding-window truncation were sent to the condensing request, which could exceed the model context window even though normal requests still fit. Use getEffectiveApiHistory, the same selection normal requests use. The stored history is unchanged; all messages are still tagged with condenseParent. Fixes Zoo-Code-Org#1823 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Zoo-Code-Org/Zoo-Code/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Required CI passed. Waiting for automated review of the latest commit. If automated review does not start, a maintainer must restart it. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
getMessagesSinceLastSummary, which ignorestruncationParent, so messages already hidden by sliding-window truncation were sent to the condensing request and could exceed the context window.getEffectiveApiHistory, the same history normal requests send. Stored history is preserved (all messages are still tagged withcondenseParent).Fixes #1823
Test plan
condense.spec.ts(fails without the fix, passes with it)core/condense,core/context-management,core/tasksuites passpnpm check-typesand lint pass🤖 Generated with Claude Code