[Chore] Make CodeRabbit completeness checks advisory - #1621
Conversation
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughTwo custom pre-merge checks in ChangesPre-merge check configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This configuration-only change makes the intended completeness checks advisory without weakening security or persistence enforcement. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Description checkExplanation The description explains the configuration changes, rationale, impact, and reported validation results. It does not follow the required template because it omits the Related GitHub Issue section, detailed Test Procedure, Pre-Submission Checklist, and other required template sections. Resolution Add the required template sections. Link an approved GitHub Issue with a
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
2 participants
What changed
Regression evidencefrom an error to a warning.Lifecycle resource cleanupfrom an error to a warning.Security boundariesandPersistence integrityas errors.assertivereview profile, check instructions, and every unrelated setting.Why this change was made
PR #1595 showed the same lifecycle work being evaluated through two overlapping mechanisms. CodeRabbit repeatedly found concrete defects through adversarial inline reviews and submitted
CHANGES_REQUESTED, including registry cleanup, post-disposal behavior, asynchronous initialization, and settings-triggered recreation. Its walkthrough then separately blocked the PR on broadRegression EvidenceandLifecycle Resource Cleanupcompleteness judgments after several fix cycles.This policy keeps inline review adversarial so concrete defects still request changes. Blocking pre-merge errors remain reserved for deterministic, unacceptable outcomes such as a concrete security-boundary bypass or persistence corruption path. Completeness, test-depth, and lifecycle-design assessments remain visible but advisory because their finite completion criteria are less stable.
Impact
CodeRabbit will continue reporting regression-evidence and lifecycle-cleanup concerns in the walkthrough, but those custom checks will no longer independently withhold approval. Concrete inline findings can still produce a normal requested-changes review, while Security Boundaries, Persistence Integrity, and the existing issue-assessment gate remain blocking.
The current CodeRabbit v2 schema accepts
warningfor custom pre-merge checks. The YAML and intended mode matrix were parsed directly; Prettier, lint, type checks, the fullpnpm testsuite, andgit diff --checkpass. No Zoo-Code-Docs update is needed because this changes repository review policy rather than extension functionality.