[Fix] Accessibility contrast checks fail during theme changes - #1613
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Related GitHub Issue
Closes: #1612
Description
Disable CSS transitions within the accessibility contrast audit before applying each VS Code theme. Contrast measurements now sample final theme colors deterministically while retaining the existing WCAG thresholds, including the 4.5:1 text requirement.
This is test-harness-only and does not change extension behavior or rendered UI.
Test Procedure
pnpm exec playwright test -c playwright-ct.config.ts src/components/ui/__tests__/AccessibilityContrast.visual.tsx --repeat-each=10 --ignore-snapshotsfromwebview-ui/(40/40 passed across four themes)pnpm testfrom the repository root (10/10 Turbo tasks passed)pnpm exec eslint --max-warnings=0 src/components/ui/__tests__/AccessibilityContrast.visual.tsxfromwebview-ui/pnpm check-typesfromwebview-ui/Host snapshot comparisons were intentionally excluded from the repeated focused run because committed visual baselines are Docker-authored; this change does not alter snapshots or rendered final states.
Pre-Submission Checklist
*.visual.tsxsnapshot inwebview-ui/. Seewebview-ui/AGENTS.md-> "When a UI change needs a snapshot".Visual Snapshots
Not applicable. Final rendered UI is unchanged; this only removes transition timing from the test harness.
Videos (interaction / animation only)
Not applicable.
Documentation Updates
Additional Notes
The contrast assertion implementation and thresholds are unchanged, so final colors below the required ratio continue to fail.
Get in Touch
Mention
@roomoteon this PR for follow-up.