[Chore] Make test bundle dependencies cache-aware - #1611
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (2)Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe change removes npm pretest bundling hooks and declares ChangesTurbo test dependency wiring
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Refactor · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change correctly moves bundle ordering into Turbo without altering test commands or coverage behavior. 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
What changed
bundleas an explicit dependency of thezoo-codetest and coverage tasks.@roo-code/types#builddependency and coverage outputs with$TURBO_EXTENDS$.pretestandpretest:coveragelifecycle hooks so Turbo owns the complete task graph.Why this change was made
The bundle prerequisite previously ran through a nested Turbo invocation inside pnpm lifecycle hooks. Making the edge visible lets Turbo schedule, hash, and cache the bundle independently while retaining the root task configuration required by other packages.
Impact
There is no product or user-facing behavior change. The immediate gain is limited to removing nested orchestration and allowing unchanged bundle work to be restored as a first-class Turbo dependency; the larger benefit is that this creates the correct prerequisite graph for follow-up coverage slicing. In the latest successful
mainrun, non-core coverage took about 3m04s on Ubuntu and 9m41s on Windows, so preserving reusable prerequisites and enabling later slice-level cache hits targets the current CI bottleneck without weakening test coverage.Validation
testandtest:coverageresolve both@roo-code/types#buildandzoo-code#bundle.zoo-codecoverage passed with all five graph tasks successful.pnpm testpassed with 8,277 tests across 472 passing test files.Closes #114.