You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The successful-search tests use an unconditional registry mock and do not assert which workspace was requested. These individual tests can remain green if workspace routing regresses, even though other tests in the suite already check that argument.
Context (who is affected and when)
Maintainers reviewing changes to task-workspace search need the normal successful execution path to protect the behavior being fixed in PR #1629. This is a test-coverage gap, not evidence that the entire suite fails to detect the regression.
Inspect the happy-path assertions around line 217: they verify the search call but not the registry lookup arguments.
To validate the gap, temporarily remove the workspace argument from the production lookup and run only the affected happy-path tests. This mutation experiment is proposed, not claimed to have been run for this issue.
Expected result
The happy-path tests assert exactly one registry lookup with the extension context and the task workspace, in addition to the existing search query/directory assertions. Removing or replacing the workspace argument must fail those tests.
Actual result
The happy-path mock returns the same manager regardless of lookup arguments. Argument assertions exist in the missing-manager and delayed-approval scenarios, but are absent from the happy-path assertions identified by the review.
App Version
Source review of PR #1629, commit 3e09b14; no released extension version was reproduced. The new test file is not yet on upstream main at filing time.
Problem (one or two sentences)
The successful-search tests use an unconditional registry mock and do not assert which workspace was requested. These individual tests can remain green if workspace routing regresses, even though other tests in the suite already check that argument.
Context (who is affected and when)
Maintainers reviewing changes to task-workspace search need the normal successful execution path to protect the behavior being fixed in PR #1629. This is a test-coverage gap, not evidence that the entire suite fails to detect the regression.
Reproduction steps
Expected result
The happy-path tests assert exactly one registry lookup with the extension context and the task workspace, in addition to the existing search query/directory assertions. Removing or replacing the workspace argument must fail those tests.
Actual result
The happy-path mock returns the same manager regardless of lookup arguments. Argument assertions exist in the missing-manager and delayed-approval scenarios, but are absent from the happy-path assertions identified by the review.
App Version
Source review of PR #1629, commit 3e09b14; no released extension version was reproduced. The new test file is not yet on upstream main at filing time.
API Provider (optional)
Not Applicable / Other
Relevant logs or errors (optional)
Original review: #1629 (comment)
Acceptance criteria:
Tracked separately at the author's request; coordinate closure with the final version of PR #1629.