-
Notifications
You must be signed in to change notification settings - Fork 578
[FIX] Fix incorrect constant reference breaking cloud config loading … #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1772) [FIX] Fix incorrect constant reference in config_registry.py Changed ConfigPluginConstants.METADATA to ConfigPluginConstants.CONFIG_METADATA to fix silent AttributeError that prevented cloud configuration plugins from loading. This caused ENABLE_HIGHLIGHT_API_DEPLOYMENT and other cloud config keys to always return False. Bug was introduced in PR #1618 (commit 808040c). Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughA metadata key lookup is updated from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
|



…(#1772)
[FIX] Fix incorrect constant reference in config_registry.py
Changed ConfigPluginConstants.METADATA to ConfigPluginConstants.CONFIG_METADATA to fix silent AttributeError that prevented cloud configuration plugins from loading. This caused ENABLE_HIGHLIGHT_API_DEPLOYMENT and other cloud config keys to always return False.
Bug was introduced in PR #1618 (commit 808040c).
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.