Skip to content

Feature/rev 1#1

Open
Zhunaidm wants to merge 17 commits intomainfrom
feature/rev_1
Open

Feature/rev 1#1
Zhunaidm wants to merge 17 commits intomainfrom
feature/rev_1

Conversation

@Zhunaidm
Copy link
Copy Markdown
Owner

Changes for Revision 1

  • Use DB Migration files that can be PR'd.
  • Improve naming conventions to be more consistent, i.e Id
  • Use Django forms for filtering views.
  • Use Text field for model fields with very large lengths.
  • Create Email template model.
  • Implement email blurb construction.
  • Setup Email Backend to print to console.
  • Ensure that validation checks follow fail-fast by checking base cases.
  • Investigate using get_object_or_404 (Removed due to not being consistent with the rest of the view/model approach).
  • Ensure that all get functions on models have a try/except for when the entry does not exist.
  • Update presigned_url to upload_id to make more descriptive.
  • Dynamically build out upload and download URLs using request information.
  • Use a base model and inherit for created_at.
  • Update Model on_delete for foreign keys to SET_NULL where data retention would be necessary.
  • Updated all Enums to use Django Integer choices for consistency.
  • Switch upload_id to text to allow easy changing of type and not being locked to UUID.
  • Streamlined logic to check whether an upload_id is valid in utilities.
  • Research Fat Model / Skinny view vs. Skinny Model / Fat View (The approach in this project is Skinny Models to separate the business and data access logic).
  • Create a form for Document Creation requests that is reused by the Documents and Customers View.
  • Some general code cleanup and updates to ensure consistency in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant