fix(export): HEC-RAS package reads raster names from result_package - #243
Merged
Merged
Conversation
…not mirrored copies ADR 0009 says result_package is the ONE place that names every path in the package; the HEC-RAS exporter had mirrored four of them. Import them instead (no import cycle: result_package pulls only the datastore/validate schemas) and name the optional soil_texture.tif there too.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #241. ADR 0009 makes
result_packagethe one place that names every package path; the HEC-RAS exporter had mirrored four names as module constants. Import them (no cycle) and name the optionalsoil_texture.tifin the contract too. Tests: export + package-contract suites green.