Skip to content

fix(security): constant-time comparison for Bearer auth tokens #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): constant-time comparison for Bearer auth tokens #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/service/api/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package api

import (
"crypto/subtle"
"encoding/json"
"net/http"
"sort"
Expand Down Expand Up @@ -77,7 +78,8 @@ func AuthMiddleware(tokenProvider func() string, storeAvailable func() bool) fun
respondError(w, http.StatusUnauthorized, "invalid_auth", "认证失败: 缺少 Authorization header")
return
}
if strings.TrimSpace(auth[7:]) != token {
provided := strings.TrimSpace(auth[7:])
if subtle.ConstantTimeCompare([]byte(provided), []byte(token)) != 1 {
respondError(w, http.StatusUnauthorized, "invalid_auth", "认证失败: 无效的认证令牌")
return
}
Expand Down
4 changes: 3 additions & 1 deletion internal/service/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package server

import (
"crypto/subtle"
"encoding/json"
"fmt"
"io"
Expand Down Expand Up @@ -367,7 +368,8 @@ func checkAuth(r *http.Request, expectedToken string) bool {
if !strings.HasPrefix(auth, "Bearer ") {
return false
}
return strings.TrimSpace(auth[7:]) == expectedToken
provided := strings.TrimSpace(auth[7:])
return subtle.ConstantTimeCompare([]byte(provided), []byte(expectedToken)) == 1
}

func (s *Server) resolveModelOrFallback(modelName string) (*provider.ResolvedRoute, error) {
Expand Down