-
Notifications
You must be signed in to change notification settings - Fork 25
Add donation card to About page #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
67598f8
8691feb
0ebc14c
faea001
2964c52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,45 @@ | |||||||||||||||||||||||
| <v-card-text> | ||||||||||||||||||||||||
| <v-row> | ||||||||||||||||||||||||
| <v-col class="mx-auto" cols="12" md="8"> | ||||||||||||||||||||||||
| <!-- 捐赠卡片 --> | ||||||||||||||||||||||||
| <v-card | ||||||||||||||||||||||||
| border | ||||||||||||||||||||||||
| class="donation-card gradient-donation clickable mb-6" | ||||||||||||||||||||||||
| color="pink-lighten-4" | ||||||||||||||||||||||||
| elevation="8" | ||||||||||||||||||||||||
| hover | ||||||||||||||||||||||||
| rounded="xl" | ||||||||||||||||||||||||
| variant="tonal" | ||||||||||||||||||||||||
| @click="openDonationLink" | ||||||||||||||||||||||||
| > | ||||||||||||||||||||||||
| <v-card-item> | ||||||||||||||||||||||||
| <div class="card-content"> | ||||||||||||||||||||||||
| <div> | ||||||||||||||||||||||||
| <div class="text-h6 font-weight-bold">请支持我们 Classworks</div> | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
| </v-card-item> | ||||||||||||||||||||||||
|
Comment on lines
+25
to
+31
|
||||||||||||||||||||||||
| <div class="card-content"> | |
| <div> | |
| <div class="text-h6 font-weight-bold">请支持我们 Classworks</div> | |
| </div> | |
| </div> | |
| </v-card-item> | |
| <v-card-title class="text-h6 font-weight-bold"> | |
| 请支持我们 Classworks | |
| </v-card-title> | |
| </v-card-item> |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The click handler is defined on both the card (line 22) and the button inside it (line 44). When the button is clicked, both click handlers will fire due to event bubbling. Consider adding @click.stop to the button's click handler to prevent the event from propagating to the parent card, or remove the click handler from one of these elements.
| @click="openDonationLink" | |
| @click.stop="openDonationLink" |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .card-content CSS class is defined but not used for any functional styling in the donation card. The div structure with this class (lines 25-30) contains unnecessary nesting with empty divs. Consider simplifying this structure or removing the unused class definition.
| .card-content { | |
| display: flex; | |
| align-items: center; | |
| justify-content: space-between; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'clickable' class is used but not defined in this component's scoped styles. While it may work if defined globally or in another component, scoped styles won't apply it here. The cursor: pointer is already set in .gradient-donation (line 458), making this class redundant. Consider removing the 'clickable' class from the v-card.