Repository navigation
fix(client): keep the API key out of connection errors - #76
Open
rexsacrorum wants to merge 1 commit into
Open
rexsacrorum wants to merge 1 commit into
rexsacrorum wants to merge 1 commit into
Conversation
The key travels in the apikey query parameter, and a requests connection error (refused connection, DNS failure, connect timeout) names the request URL, so printing or logging it showed the key. The client now replaces it with REDACTED in the messages of the error and of the exceptions it wraps; the exception objects and their types stay the same.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client sends the key in the
apikeyquery parameter, and arequestsconnection error names the request URL, so printing or logging it shows the key:The client now replaces the key with
REDACTEDin the messages of the error and of the exceptions it wraps. The exceptions are the same objects, soexcept requests.ConnectionErrorand the retries work as before.