Repository navigation
fix(mobile): adopt core 2.69.1, a converted table is named after the heading above it - #60
Merged
Merged
Conversation
…heading above it Core core-2.69.1-core.h3b2f026d7dfd6c7d, built by CI from ZenNotes/zennotes 86e98b49 (the v2.69.1 release commit); core:adopt checked SHA-256, SHA-512, packed versions and clean-source provenance. What it brings here: Convert to database offers the heading right above the table as the database's name in a long note too. It read the editor's syntax tree, which spans the whole note even while the parse has not reached the table, so in a note opened a moment ago it could offer an earlier heading; it now parses up to the table before choosing. The name could be edited before saving, so nothing was saved under it unseen. The rest of 2.69.1 needs a desktop: renames on Windows, the MCP server's task lines, and What's New. No new bridge method, palette command or long-press entry. Checked: npm run upstream, npm test (253), npm run sync; in the shell (vite preview at phone size), a note with # Early, sixty paragraphs, then # Roadmap over a table: the table menu offered "Roadmap" and converted it to Roadmap.base with [[Roadmap]] in its place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts core 2.69.1 (
core-2.69.1-core.h3b2f026d7dfd6c7d, built by CI from ZenNotes/zennotes86e98b49, the v2.69.1 release commit).Not a release: no version bump, and it waits for the next iPhone release. The core release is still a draft on ZenNotes/zennotes; it is published once the phones ship on it.
What it brings
Convert to database offers the heading right above the table as the database's name in a long note too. It read the editor's syntax tree, which spans the whole note even while the parse has not reached the table, so in a note opened a moment ago it could offer an earlier heading; it now parses up to the table before choosing (ZenNotes/zennotes
ba74c54f). The name could be edited before saving, so nothing was saved under it unseen.The rest of 2.69.1 needs a desktop: renames on Windows, the MCP server's task lines, and What's New. No new bridge method, palette command or long-press entry.
Checks
npm run core:adopt -- core-2.69.1-core.h3b2f026d7dfd6c7d --source 86e98b49d6a0be5e9c52e4e9b1c414977cbfbd29: SHA-256, SHA-512, packed versions and clean-source provenance verified. The vendoredheadingAbovecallsensureSyntaxTree(state, pos, 50).npm run upstream(boundary check and typecheck),npm test(253 pass),npm run sync.vite previewat phone size, on an on-device vault: a note with# Early, sixty paragraphs, then# Roadmapover a table. The table cell's menu offered "Roadmap", and Convert madeRoadmap.baseand left[[Roadmap]]where the table was.How to test locally
npm ci && npm run build && npx vite preview --port 4188; open it at phone size, then Get started, On this iPhone.# Earlyat the top, about fifty paragraphs, then# Roadmapwith a table under it.