Repository navigation
Release 1.25.0 (build 41): adopt core 2.69.0 - #59
Merged
Merged
Conversation
The desktop app's own text dropped the long dash in 2.68.0; the phone shell's strings were left. Rewritten with commas, colons and parentheses: the Tags view's empty hint, the Browse drawer's notes on an external folder, an iCloud vault's deletion and a remote vault's removal, the remote vault's name line (now "Name" (host)), the error for an attachment over the upload limit (now two sentences), the iCloud plugin's "iCloud is not available" error, and the sync engine's scan-cache error. Comments and console warnings are unchanged.
The section list hides MCP and CLI, and Keymap on a phone, by their labels, but Settings search builds its results from app-core's index and listed their settings anyway: searching "review" offered Review agent edits, and a tap opened the MCP page the list hides. Core 2.69 puts the section's id on each result (`data-settings-result-category`); the results of the hidden sections are hidden the same way, at phone width, where the list hides them.
…s when it goes Since desktop 2.68.0, an assistant that edits a note through MCP leaves what the note said before in `.zennotes/agent-edits/<note>.json` until the edit is reviewed in the desktop app, and Cloud sync carries the record. This app moved and deleted notes with their comments and creation dates but not with that record: renaming or moving a note here stranded the review at the old path, where the desktop could no longer offer it, and deleting a note left the record behind for a note that was gone. The record is now a third sidecar, handled as desktop's note-sidecars.ts handles it: it moves with a rename, a move, Trash and Restore, and a folder rename; it goes with Delete, Empty Trash and a folder's deletion; and a record already at a destination with no note beside it belongs to nobody, so a moved note replaces it and a new or duplicated note never inherits it. This app still does not review edits itself. Checked: three new tests in vault-lifecycle.test.ts (rename, move, Trash and back, Empty Trash; folder rename and both deletions; a new note and a copy over orphaned records), all three failing on the previous vault-fs; typecheck and the whole suite.
…s so Core core-2.69.0-core.h27a2c5df8414d1dd, built by CI from ZenNotes/zennotes d1344076 (the v2.69.0 release commit); core:adopt checked SHA-256, SHA-512, packed versions and clean-source provenance. What it brings here: when another device moves a Cloud vault to end-to-end encryption, this app's sync host retires the link to the old vault and the app says it was replaced by an encrypted one, instead of repeating the service's "Update ZenNotes" on every sync; an encrypted vault shows its real name as soon as encryption is unlocked, and its backups say to save an archive in the desktop app instead of offering a button the bridge refuses; Settings search results carry their section's id, which the next commits use; requestCreateBrowseNote, for the Browse row; and shortcuts that switch, reopen or create a note no longer act behind a dialog on a hardware keyboard, nor do the Tasks calendar's keys. The 2.69.0 additions that need a desktop stay off: Settings → MCP → Server token (its bridge methods are optional and this bridge leaves them out, so where the MCP section shows, on an iPad, it reads as nothing to share), and What's New. No new palette command needs the hide list.
Browse listed a folder's notes with a New folder row under them but no way to start a note there: a note could only be made at the top, from the create row or the New sheet, and then moved with More → Move to…, and core's "New Note in Current Folder" means the open note's folder, not the one on screen. Reported on Android (ZenNotes/zennotesandroid#108); this shell's Browse is the same. A New note row now sits above New folder in every Browse folder, the root included. It closes the drawer and calls core's requestCreateBrowseNote with the folder on screen, which creates the note there the way the create row's Note does and opens it on its title, so naming it is the next thing typed. It shares New folder's muted look under its own class, and the welcome note mentions it beside New folder. This needs core 2.69 (requestCreateBrowseNote, ZenNotes/zennotes f9e219b2), so it lands with that adoption: against core 2.68.0 the import does not exist. Checked against a rehearsal core built from that tree: typecheck, 250 tests, build, and the built app in a 375x812 phone viewport with an on-device vault: Browse, New folder "Projects", into it, New note, which opened "Untitled" with its title selected and wrote inbox/Projects/Untitled.md; the welcome note carries the new sentence. Not run in an iOS simulator or on a device (WebKit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.25.0 (build 41) on core 2.69.0.
.zennotes/agent-edits/<note>.json) moves with its note and goes when it goes, as on desktop; three new tests, failing on the previous vault-fs.Local:
npm run upstream(boundaries + typecheck), 253 tests,npm run sync, the production audit gate (12 low/moderate). In the browser preview with a core of the same content hash: phone width, Settings search hides the MCP, CLI and Keymap results and nothing else; iPad width, Keymap lists no agent edit review key; Browse → New note creates the note in the browsed folder with its title focused.