Repository navigation
Release 1.24.0 (build 40): adopt core 2.68.0 - #58
Merged
Merged
Conversation
…ented Core core-2.68.0-core.h6e3db1e19bc2b662, built by CI (ZenNotes/zennotes boundary run 38327475651) from 881baa6a, the v2.68.0 tag commit, and adopted with core:adopt pinned to that source (SHA-256, SHA-512, packed versions and clean-source provenance checked). The lockfile moves the three @ZenNotes pins and adds @codemirror/merge 6.12.2, which app-core now depends on for the desktop's agent edit review; it resolves onto the shell's own CodeMirror state, view and language, so the singleton check holds. For the phones it brings: - Indenting leaves headings at the margin (#925): the toolbar's indent button, Tab and Vim's >> no longer turn a heading into an indented code block. The rest of a selection still indents, and a notice says why the heading stayed. - Preview keeps the column widths a table was given in the editor and scrolls a wide table sideways instead of squeezing its columns (#920). - App text without long dashes. The demo tour's notes are now named "00 Start Here" and so on; the next commit teaches this shell's vault to find a tour seeded under the older names. The desktop-only additions stay off. The bridge contract's new methods (sendUsageCount, listAgentEdits, readAgentEdit, writeAgentEdit) and supportsAgentEditReview are optional and this bridge leaves them out, so the store keeps no agent edit records (no Review Agent Changes entries, no review banner) and never sends a usage count; the usage setting renders only on desktop, and Review agent edits sits in the MCP section the shell already hides. What's New opens only on a desktop host: the store's launch check and openWhatsNew (behind the palette command and :whatsnew) return early unless hostKind is desktop (ios here), and the palette command also needs runtime desktop. Every title-matched hide in the shell still matches the new core. npm run upstream, 246 tests, Capacitor sync and the CI build-for-testing pass on this commit alone.
Core 2.68.0 renamed the demo tour's notes from "NN <long dash> Title" to "NN Title" (00 Start Here.md and so on), and desktop's vault.ts (olderDemoTourNotePaths) learned to find a tour seeded under the older names. MobileVault keeps its own copy of that code, which knew only the current names. On a phone holding a tour from an earlier build, or one synced from a desktop, the core still sees the tour (isDemoTourStartPath accepts both names) and offers Remove Demo Tour Notes and Regenerate Demo Tour Notes, but Remove left all 17 old notes in place and Regenerate wrote a second tour beside them, though its confirmation promises to overwrite the first. Both now do what desktop does: regenerating first deletes the tour notes still under the older names, and removing deletes them as well and reports them, so the core drops them from its note list. The match is desktop's, imported from the adopted shared-domain (currentDemoTourPath) rather than copied: exact on the old separator, and only for a name whose corrected form is one of the tour's own notes. A note of the user's that only looks related (a tour title behind a middle dot or an en dash, or the old separator in front of a title the tour never had) is never touched. demo-tour.test.ts seeds the older tour beside four such notes and checks Remove, Regenerate and a tour under the current names. Against the previous MobileVault the Remove and Regenerate cases fail, and a deliberately broad separator match fails on the middle-dot note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.24.0 (build 40) on core 2.68.0.
Desktop-only additions stay off: the new bridge methods (sendUsageCount, listAgentEdits/readAgentEdit/writeAgentEdit) and supportsAgentEditReview are optional and not implemented here, so there are no agent edit records, review entries or usage counts; What's New returns early on a non-desktop host (hostKind ios), and its palette command and
:whatsnewneed runtime desktop. No new palette command needed hiding, and every title-matched hide (palette titles, settings sections and sub-tabs, DEVICE_HIDDEN_MENU_ITEMS, the tags empty-state patch, the mobile.css title/aria-label/placeholder and settings-id selectors) still matches the new core.Local:
npm cileaves the lockfile unchanged; boundaries,npm audit --omit=dev --audit-level=high, typecheck, 250 tests (246 on the adoption commit alone), the Vite build, Capacitor sync and CI's build-for-testing pass; Release settings read 1.24.0 (40) for App, ShareExtension and ZenWidgets. AppUITests on scratch iOS 27 simulators: iPhone 17 Pro Max 7 passed, iPad Pro 13-inch 3 passed, no failures (the six account-backed Cloud flows skip without the QA account). On the iPhone simulator: the toolbar's indent button left a heading in place with its notice, a table with stored widths scrolled sideways in Read mode, the palette offered no What's New or Review Agent Changes, and Regenerate and Remove each handled a tour planted under the 2.67.0 names while two lookalike notes survived.