⚡ Bolt: [performance] Optimize opkg SBOM parsing#106
Conversation
Replace `str.splitlines()` and generic dictionary allocations with direct string slice searches (`str.find`) when parsing opkg blocks. Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized
get_opkg_sbominscripts/make-sbom.pyto use direct string searches (str.find) instead of splitting lines and allocating intermediary dictionaries for every single block.🎯 Why: Parsing large opkg index files containing tens of thousands of packages caused massive intermediate list and dictionary allocations, leading to high CPU overhead from garbage collection and string creation.
📊 Impact: Reduces execution time by ~25% (0.70s -> 0.52s on a 50k mock package index) and drastically lowers memory pressure by extracting only the required fields.
🔬 Measurement: Verify by generating an SBOM from a large opkg index file and observing the reduction in execution time and memory footprint compared to
master.Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
PR created automatically by Jules for task 1628368061461324355 started by @manupawickramasinghe