🧪 Add test for is_rknn_compatible#9
Conversation
Added a new file `frigate/test/test_rknn_converter.py` with test cases to comprehensively test the `is_rknn_compatible` method in `frigate/util/rknn_converter.py`. The tests cover standard flows like `get_soc_type` returning supported and unsupported SoCs, as well as testing valid vs invalid explicit and implicit model types. Dependencies such as `cv2`, `numpy`, and `peewee` are correctly mocked using `sys.modules` to make the test environment-agnostic. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation failedThis PR was automatically closed because the description does not follow the pull request template. Issues found:
Please update your PR description to include all required sections from the template, then reopen this PR.
|
🎯 What: The testing gap addressed
The
is_rknn_compatiblemethod infrigate/util/rknn_converter.pywas not tested. It has clear behavior based on string matching and checking support arrays, so it was a prime candidate for tests to ensure future changes do not introduce bugs.📊 Coverage: What scenarios are now tested
The new test module
frigate/test/test_rknn_converter.pytests:model_typevalues.model_typeis missing, but a valid/invalid model type is inferred.✨ Result: The improvement in test coverage
The test coverage for
frigate/util/rknn_converter.pyhas been significantly improved, directly testing the logical branches ofis_rknn_compatible. Test fixtures make use ofunittest.mockto ensure isolation and robustness when dependencies are not present.PR created automatically by Jules for task 921988146595792646 started by @manupawickramasinghe