Skip to content

🧪 Add test for is_rknn_compatible#9

Merged
ManupaKDU merged 1 commit into
devfrom
test-is-rknn-compatible-921988146595792646
May 22, 2026
Merged

🧪 Add test for is_rknn_compatible#9
ManupaKDU merged 1 commit into
devfrom
test-is-rknn-compatible-921988146595792646

Conversation

@ManupaKDU
Copy link
Copy Markdown

🎯 What: The testing gap addressed
The is_rknn_compatible method in frigate/util/rknn_converter.py was not tested. It has clear behavior based on string matching and checking support arrays, so it was a prime candidate for tests to ensure future changes do not introduce bugs.

📊 Coverage: What scenarios are now tested
The new test module frigate/test/test_rknn_converter.py tests:

  • When the SoC type cannot be determined.
  • When an unsupported SoC is present.
  • When a supported SoC is present along with valid/invalid explicit model_type values.
  • When a supported SoC is present, model_type is missing, but a valid/invalid model type is inferred.

Result: The improvement in test coverage
The test coverage for frigate/util/rknn_converter.py has been significantly improved, directly testing the logical branches of is_rknn_compatible. Test fixtures make use of unittest.mock to ensure isolation and robustness when dependencies are not present.


PR created automatically by Jules for task 921988146595792646 started by @manupawickramasinghe

Added a new file `frigate/test/test_rknn_converter.py` with test cases to comprehensively test the `is_rknn_compatible` method in `frigate/util/rknn_converter.py`. The tests cover standard flows like `get_soc_type` returning supported and unsupported SoCs, as well as testing valid vs invalid explicit and implicit model types. Dependencies such as `cv2`, `numpy`, and `peewee` are correctly mocked using `sys.modules` to make the test environment-agnostic.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown

PR template validation failed

This PR was automatically closed because the description does not follow the pull request template.

Issues found:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please update your PR description to include all required sections from the template, then reopen this PR.

If you used an AI tool to generate this PR, please see our contributing guidelines for details.

@github-actions github-actions Bot closed this May 22, 2026
@ManupaKDU ManupaKDU reopened this May 22, 2026
@ManupaKDU ManupaKDU merged commit 8b8bc02 into dev May 22, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant