Skip to content

🔒 Fix SQL execution for SQLite Vec Queue Database embeddings deletion#15

Merged
manupawickramasinghe merged 1 commit into
devfrom
fix-sqlitevecq-sql-injection-13088560508748280241
May 22, 2026
Merged

🔒 Fix SQL execution for SQLite Vec Queue Database embeddings deletion#15
manupawickramasinghe merged 1 commit into
devfrom
fix-sqlitevecq-sql-injection-13088560508748280241

Conversation

@ManupaKDU
Copy link
Copy Markdown

🎯 What: The issue reported an SQL injection in frigate/db/sqlitevecq.py via string concatenation in delete_embeddings_thumbnail. The existing code parameterized the values using ? properly to mitigate SQL injection. However, it was missing handling for empty lists, leading to potential syntax errors WHERE id IN (), and parameters weren't explicitly passed as a tuple.
⚠️ Risk: If an empty list of event_ids is passed, it results in a SQLite syntax error, potentially crashing the application or the background cleanup process. Although the original code parameterized correctly for non-empty lists, SAST tools often flag missing explicit bounds or tuple structures in such dynamic IN clauses as risks.
🛡️ Solution: Added a check to immediately return if the event_ids list is empty, preventing the generation of an invalid SQL statement. Also explicitly cast event_ids to a tuple in the execute_sql call to ensure the backend strictly interprets it as positional parameters instead of potentially malformed input types. The same fix was also correctly applied to the adjacent delete_embeddings_description function.


PR created automatically by Jules for task 13088560508748280241 started by @manupawickramasinghe

This addresses an issue reported as SQL injection via string concatenation in `frigate/db/sqlitevecq.py`. While the parameters were already passed securely using `?` placeholders (preventing actual SQL injection), this commit converts the parameter list to a tuple explicitly for clarity and robustness, and prevents syntax errors (`id IN ()`) when the `event_ids` list is empty by introducing an early return.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe manupawickramasinghe merged commit c0bc6c4 into dev May 22, 2026
1 check failed
@github-actions
Copy link
Copy Markdown

PR template validation failed

This PR was automatically closed because the description does not follow the pull request template.

Issues found:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please update your PR description to include all required sections from the template, then reopen this PR.

If you used an AI tool to generate this PR, please see our contributing guidelines for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants