Skip to content

fix(api): Add fallback image loading from triggers directory#14

Merged
ManupaKDU merged 1 commit into
devfrom
fallback-trigger-images-841167091730216318
May 22, 2026
Merged

fix(api): Add fallback image loading from triggers directory#14
ManupaKDU merged 1 commit into
devfrom
fallback-trigger-images-841167091730216318

Conversation

@ManupaKDU
Copy link
Copy Markdown

Added a fallback logic in create_trigger_embedding (in frigate/api/event.py) to search the triggers directory for thumbnail images when an Event object is not found in the database. This logic ensures that valid .webp image triggers are loaded successfully even if the matching Event record has expired or is missing. Also updated error handling to return valid JSONResponse errors when the retrieved event is not an object.


PR created automatically by Jules for task 841167091730216318 started by @manupawickramasinghe

…_embedding

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU ManupaKDU merged commit d04b46c into dev May 22, 2026
1 check failed
@github-actions
Copy link
Copy Markdown

PR template validation failed

This PR was automatically closed because the description does not follow the pull request template.

Issues found:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please update your PR description to include all required sections from the template, then reopen this PR.

If you used an AI tool to generate this PR, please see our contributing guidelines for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant