Skip to content

🎨 Palette: Extract and humanize foreground service notification strings #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manupawickramasinghe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Extract and humanize foreground service notification strings #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,6 @@
## 2026-05-20 - Mouse Hover States for Custom Selectors
**Learning:** Custom drawable selectors (like `ic_shutter.xml`) on Android often define `state_pressed` and `state_focused` but omit `state_hovered`. This strips visual feedback for users navigating with pointer devices (mice, trackpads) on environments like Chromebooks or Samsung DeX, degrading the user experience compared to native components.
**Action:** Always include `android:state_hovered="true"` alongside focus and pressed states in custom interactive background selectors to ensure universal visual feedback across all input methods.
## 2024-03-24 - Extract Foreground Service Notification Strings
**Learning:** System-level UI components like Notification channels and actions are directly visible to users in Android settings and lock screens. Using hardcoded, developer-centric terminology (like 'Kill' or 'CHANNEL_ID') creates a jarring and unprofessional user experience.
**Action:** Always extract notification channel names, descriptions, and action labels into localized string resources. Replace aggressive technical terms with standard, user-friendly mobile UX phrasing (e.g., 'Stop' instead of 'Kill', 'Tap' instead of 'Click').
10 changes: 5 additions & 5 deletions app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ class Cam : Service() {
"start" -> {
val channel = NotificationChannel(
CHANNEL_ID,
CHANNEL_ID,
getString(R.string.notification_channel_name),
NotificationManager.IMPORTANCE_DEFAULT
)
channel.description = "RemoteCam run"
channel.description = getString(R.string.notification_channel_desc)
val notificationManager = getSystemService(NotificationManager::class.java)
notificationManager.createNotificationChannel(channel)

Expand All @@ -72,9 +72,9 @@ class Cam : Service() {

val builder =
NotificationCompat.Builder(this, CHANNEL_ID)
.setContentTitle("RemoteCam (active)")
.setContentText("Click to open").setOngoing(true)
.setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, "Kill",pendingIntentKill)
.setContentTitle(getString(R.string.notification_title))
.setContentText(getString(R.string.notification_text)).setOngoing(true)
.setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop), pendingIntentKill)
.setContentIntent(pendingIntent)


Expand Down
7 changes: 7 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@
<string name="error_no_browser">No web browser found. Please install a browser to view the repository.</string>

<!-- Stop Confirmation Dialog -->
<!-- Notification Strings -->
<string name="notification_channel_name">Camera Service</string>
<string name="notification_channel_desc">Background service to keep the remote camera running</string>
<string name="notification_title">RemoteCam (active)</string>
<string name="notification_text">Tap to open</string>
<string name="notification_action_stop">Stop</string>

<string name="stop_confirmation_title">Stop Server?</string>
Comment on lines 50 to 58
<string name="stop_confirmation_message">This will stop the camera stream and close the application.</string>
<string name="stop_confirmation_positive">Stop</string>
Expand Down