feat: add Kodi and RetroArch playback controls#554
Merged
wizzomafizzo merged 3 commits intomainfrom Mar 15, 2026
Merged
Conversation
Add stop, play/pause, fast forward, rewind, next, and previous controls to all Kodi launchers via shared kodiControls factory. Thread context.Context through ControlFunc signature and Kodi client methods for proper cancellation support. Add input validation for GoTo direction parameter.
- Thread LauncherCtx from LauncherManager to all commands, not just media-launching ones, so control commands get a cancellable context - Use sync.Once for ZapScript command map initialization instead of rebuilding on every lookup - Rename ServiceContext fields for clarity: Cfg→Config, LSQ→LaunchSoftwareQueue, PLQ→PlaylistQueue - Remove local variable aliases in readerManager, use svc.* consistently - Add skipped test for expression propagation in control scripts, blocked by go-zapscript#2
Add playback controls (save_state, load_state, toggle_menu, toggle_pause, reset, fast_forward, stop) to EmuDeck launchers using RetroArch emulators. Uses script-based controls with RetroArch's default keyboard hotkeys. Standalone emulator launchers are unaffected. Also fix all pre-existing lint issues across the codebase: gosec G118 (context cancel), noctx (httptest), prealloc, and revive line-length.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**controlZapScript command for triggering launcher controls from scriptscontext.ContextthroughControlFuncfor cancellation supportServiceContextto reduce parameter threading in service layer