Repository navigation
MIT-618: add the marklassian mistune 3.4 GitHub task (batch 4) - #168
Merged
Merged
Conversation
…-618) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
…(MIT-618) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tools/eval/github_tasks.pygets 1 more verified GitHub task, for 6 in all. Zach wants 20, so this is well short. I stopped at the turn budget and kept the bar where it was. The other leads in the brief all failed it (see the rejected candidates).upstream_changegh-marklassian-link-labelsmistune-3.4-label-parsed-firstissue_urlis the PR, as the README allows.base_commitis the merge's first parent,3ebadd3.uv pip install --exclude-newer=... -e . pytest==9.1.1 jsonschema, then themistune==3.4.0pin. The base caps mistune below 3.4, and the pin installs over that cap. The install is a few MB.state.in_linkorstate.in_image. Instead, the converter decides link and image context from the token tree and link marks.Base failing output (containerized)
tests/test_mentions.py, the whole file. At the fix sha it has 26 tests.test_jira_mention_in_formatted_link_label_keeps_all_marks, plus five existing link and image-alt mention tests..scratch/helper that callsrepos.materialize,repos.prepareandrepos.run_testswithcontainer.run, the same stepsagent_eval.py checkruns. Containers ran one at a time, none were left behind, and--on-hostwas never used.Cause-word checks
parses link labelsparses link and image labelsbefore it knowsnew link parser3.4labels before,label before,parsed beforeandparses the label. A fix that only treats the symptom says them too ("strip mentions from the label before building the link mark"). The record's comment says so.3.4is a non-version word.mentionsagainst:tests/test_mentions.pyat the fix sha;mention,link text,alt text), in both directions;_parse_jira_mention,_inline_to_adf,_create_media_node,_contains_jira_mention_literal,_contains_image) and of the failing tests;src/marklassian/converter.py(git show 3ebadd3:src/marklassian/converter.pyfrom the repo cache).converter.py: still no hits.in_linkhits the base source, as expected. That is why it andin_imageare not cause words.refactorwas dropped as too generic, and barelink parserwas narrowed tonew link parser...._link_context_remains_non_mention,..._image_alt_preserves_complete_formatted_text). The fix's own converter comment states the cause, but the agent never sees the fix tree.3.4. It is added to the expected set intest_the_cause_words_grader_v2_skips_are_exactly_the_versions.Rejected candidates
This batch:
tests/test_ucum_pint.pyhas a comment stating the cause ("pint >= 0.26.2 rejects "[" and "]" as unknown operators") and a test name stating the fix (..._reaches_pint_without_brackets_...).tests/test_cli.pyleaves a repr change that touches tests only.URL.databasequoting): the change is SQLAlchemy ticket 11234 in the 2.1.0b1 section ofchangelog_21.rst, released before the cutoff.not_strong/em_strong2patterns): the KeyError names the missing pattern. The laid-over test's name and itsderegister("not_strong")monkeypatch show the fix. The repo is 61 MB.StreamReaderattributes): 122 MB repo, a Bittensor deployment with a large dependency set, and the fix mixes aiohttp and urllib3 2.8 changes.CancelScopepropagates nativeTask.cancel()): the fix changes no test.httpx2): the downstream PRs found add a dependency, not code.From the brief, not re-checked: harlequin#1208, constellations#719, datagrunt#375, fakesnow#457/#459, marimo#11525, uk_address_matcher#636, citibike-warehouse#2, fraud-ring-detection#3, DuckDB_ML#1, calcofi4py#2, ftw-global-data-catalog#32, datarecord#103, credit-matrix#160, light-labs#98, lawless-waf#27, decisionsmith#21, discord/access#709, dace#2634, covjson-msgspec#276, vcrpy#1094, sqlmodel-export#2, platefold#33, tugboat#146, requests-http-signature#45, skosprovider_sqlalchemy#129.
The candidates in PR #164, #165 and #167 were not re-checked either.
Why
Ticket: MIT-618 (fourth batch), the GitHub-task eval. These are real post-cutoff tasks for the arms run.
How it was tested
server/tests/test_eval_grader.pyandserver/tests/test_eval_repos.pypass.make checkpasses after mergingorigin/feature/eval-setup(already up to date).Learned
uv pip install <pin>after-e .installs a version above the project's own cap (mistune<3.4), so a task can pin a release the base refuses."anyio 4.16","urllib3 2.8","sphinx 9.2") mostly finds lockfile refreshes, security bumps and docs-build changes. The few code fixes found were either missing a test change or touched only tests. Issues that name a mechanism would be a better place to search.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y