feat: added conversion code from many plot types to curve profile#32
Merged
Conversation
RonHeck
approved these changes
May 2, 2025
|
|
||
| public static Vector operator *( double b, Vector a ) | ||
| { | ||
| return new Vector( a.X * b, a.Y * b, a.Z * b ); |
Collaborator
There was a problem hiding this comment.
You can keep logic at one place.
Suggested change
| return new Vector( a.X * b, a.Y * b, a.Z * b ); | |
| return a * b; |
| var l = Math.Sqrt( X * X + Y * Y + Z * Z ); | ||
| return l == 0.0 | ||
| ? new Vector( 0 ) | ||
| : new Vector( X / l, Y / l, Z / l ); |
Collaborator
There was a problem hiding this comment.
why not using the operator?
Suggested change
| : new Vector( X / l, Y / l, Z / l ); | |
| : this / l; |
Schnjan
force-pushed
the
feature/CurvePlotConversion
branch
from
f0a7c27 to
259a818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds conversion code to curve profile. This is needed to display plots of different types in the cad element.