Pensar - auto fix for Unsanitized User Input in Log Messages#23
Open
pensarappdev[bot] wants to merge 1 commit into
Open
Pensar - auto fix for Unsanitized User Input in Log Messages#23pensarappdev[bot] wants to merge 1 commit into
pensarappdev[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A logging vulnerability (CWE-117) existed in the
user_lookup_snsmethod where user-controlled input was interpolated directly into the log message without sanitization. To remediate this:_sanitize_for_loginUtils, which replaces newlines and carriage returns with escaped representations and removes ANSI escape sequences from the input string.logger.info(f"Pulling {user}'s tweets")statement was changed to use the sanitized version:logger.info(f"Pulling {self._sanitize_for_log(user)}'s tweets").This ensures that any potentially malicious input injected via the
userparameter cannot disrupt or forge log output.More Details
userparameter comes from external input and is directly interpolated into a log message without sanitization. If an attacker supplies a value containing newline (\n), carriage-return (\r), or ANSI escape characters, they can inject forged or misleading log entries, corrupt log files, or tamper with log-based alerting systems. This is an instance of Improper Output Neutralization for Logs (CWE-117).