Skip to content

Fix offline fallback auth and config generation#28

Merged
YuWan-030 merged 1 commit into
YuWan-030:1.20from
F1xGOD:1.20
Jul 12, 2026
Merged

Fix offline fallback auth and config generation#28
YuWan-030 merged 1 commit into
YuWan-030:1.20from
F1xGOD:1.20

Conversation

@F1xGOD

@F1xGOD F1xGOD commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes two Forge 1.20.1 regressions around offline fallback and config generation.

  • Fix auth.yggdrasil.apiRootWhitelist config path so Forge no longer keeps correcting trueuuid-common.toml and creating repeated .bak files.
  • Keep default player-facing messages as trueuuid.* translation keys, so chat/title/disconnect text follows the client language: Chinese clients use zh_cn, other clients use en_us.
  • Keep generated config comments bilingual, English-first plus Chinese.
  • Stop offering offline-data migration before the player is actually verified as Mojang/Yggdrasil.
  • Move migration confirmation into a second verified-login query, preserving the verified profile until the player confirms.
  • Honor allowOfflineOnFailure=false.
  • Tighten Yggdrasil whitelist checks to host matching instead of substring matching.

Avoid offering offline data migration before a premium/Yggdrasil account is verified, so true offline clients can fall back without seeing a premium migration prompt or getting stuck.

Move migration confirmation into a second verified-login query that preserves the pending verified profile, then migrates only after explicit confirmation.

Fix Forge TOML generation for auth.yggdrasil.apiRootWhitelist to stop repeated config correction backups, and make generated config comments English-first while keeping trueuuid.* translation keys for client-language chat/title text.

Honor allowOfflineOnFailure=false and tighten Yggdrasil whitelist validation to host matches instead of substring matches.
@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

hey guys, i think this is a really good mod, and has a big perspective for other platforms like fabric / spigot, paper etc... if possible i would love to contribute here, although unfortunately i do not speak Chinese, so if you guys need i will use translators, i would love to speak to the main devs, i noticed that @wish131400 is the biggest contributor, and would love to speak to them or any other enthusiasts

TRANSLATED TO CHINESE (not sure if this is correct):
大家好,我觉得这个模组非常不错,而且在 Fabric、Spigot、Paper 等其他平台上也有很大的发展潜力。

如果可以的话,我很愿意为这个项目做出贡献。虽然很遗憾我不会说中文,但如果有需要,我可以使用翻译工具来交流。

我也很希望能和主要开发者聊一聊。我注意到 @wish131400 是目前贡献最多的人之一,所以我很想和他,以及其他对此项目感兴趣的开发者或爱好者交流。

@wish131400

Copy link
Copy Markdown
Contributor

感谢您提供的内容修复,我认为十分合理,更加符合工程逻辑,pr通过后我会稍加修复测试发布新版本,感谢您对于本项目做出的贡献,由于目前项目作者忙于生活,目前主要由我在进行forge1.20.1和neoforge1.21.1的版本更新维护,对于其他的平台我目前还没有想法,如果你感兴趣的话可以在此留言,我可以帮你向作者询问~

@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

Yes! That would be awesome, i am currently looking for projects to take on, and help maintain / make updates and support for different mod loaders, since i have a lot of time available and im running out of ideas on my own projects, that would be great if i could contribute to this or other projects, thanks a lot

TRANSLATED TO CHINESE:
好的!那太棒了!

我最近正好在寻找一些可以参与、维护和长期贡献的项目,也很愿意帮助开发更新、修复问题,以及为不同的模组加载器提供支持。因为我目前有比较充足的时间,而且自己项目的想法也暂时有些枯竭,所以如果能够参与这个项目,或者帮助其他类似项目,我会非常开心。

如果方便的话,麻烦您帮我向作者询问一下,非常感谢!

@wish131400

Copy link
Copy Markdown
Contributor

作者表示欢迎,可以留个联系方式吗,我们通常会使用QQ或者是wecaht

@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

可以的!我刚注册了微信,这是我用于项目交流的微信号:wxid_t47kxawmbevm22。您方便的时候加我就好。

@wish131400

Copy link
Copy Markdown
Contributor

我好像搜不到啊,你看看你是不是设置了不可以通过微信号加好友

@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

我已经开启了通过微信号添加好友。可能是因为我的账号刚注册不久,暂时还搜不到。要不您把您的微信号发给我,我来加您?

@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

我刚刚修改了微信号,可能还没有立即生效。如果您觉得更方便,我也可以发二维码给您。

@wish131400

Copy link
Copy Markdown
Contributor

发二维码也行,我直接扫描加你

@F1xGOD

F1xGOD commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

我该怎么办?

@wish131400

Copy link
Copy Markdown
Contributor

帮你验证了

@YuWan-030

Copy link
Copy Markdown
Owner

Hello, I'm the original author. I'm glad you saw and appreciated this project. The meaning of open source is to allow more people with technical skills to contribute to building and maintaining an idea into a project that can go live. Welcome to join this project.

@YuWan-030 YuWan-030 merged commit 99cc1f5 into YuWan-030:1.20 Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants