Repository navigation
Conversation
|
This looks nice, btw can something be done for auto soft restart after exploit completes. |
|
This is an exploit which depends on race and because of that the nature of the exploit is that it is not deterministic. I don't think this is a good idea nor this is something worth it to because of the exploit nature and that we can go days without hard rebooting the device. |
Will try to integrate this tho |
Yes sure 👍 |
Thank you @chisewaguri for the response, I use this autostart in practice and it works 100% of the time. I think it's really important for the end user to have the autostart, because it means that kernelsu-modules will be loaded after restart and there is nothing to worry about (keep in mind the complexity). I suppose that even if it doesn't work for a particular user - there is no issue to jot enable this option or if it's not working and causing reboots - then it will auto-disable after 3 attempts. Given that could you please re-consider, I still think it's an important feature for the ones who reboots their phones or don't want to recall how to restart root after 1y of no-reboots. |
Yes I also think this feature isn't bad at all and keeping it optional (and disabled by default) is a good move. |
I saw #165 seems abandoned - so prepared this one: I suppose back-off after 3 failed boots should be ok so the users could try and in case it's not working it will be disabled. It's opt-in for the ones who wants root and kernelsu modules autostart on their phones or developing something tricky which requires a lot of reboots.