Repository navigation
feat(manager): add BakaSU support - #415
Merged
Merged
Conversation
Detect org.bakasu.bakasu alongside KernelSU/ReSukiSU/KowSU for ksud provisioning (manifest query, Kotlin package list, root-script libksud.so fallback); README updated. ReSukiSU entries kept for backward compatibility.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The native wildcard can select and execute a lookalike package’s library as root.
1 open finding
What changed in this PR
Adds future BakaSU manager support across package discovery, ksud resolution, and documentation.
Changes:
- Adds BakaSU package visibility and Kotlin-side
ksudextraction. - Adds native fallback lookup for BakaSU.
- Updates bilingual setup documentation.
| File | Description |
|---|---|
src/core/attack/ops.cpp |
Adds BakaSU native-library fallback. |
AndroidGhostlockRepository.kt |
Detects BakaSU and copies its ksud. |
AndroidManifest.xml |
Adds BakaSU package visibility. |
README.md |
Documents BakaSU support. |
README_ZH.md |
Documents BakaSU support in Chinese. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| " KSUD=$(find /data/app -path '*/com.resukisu.resukisu*/lib/arm64/libksud.so' 2>/dev/null | head -1)\n" | ||
| "fi\n" | ||
| "if [ ! -x \"$KSUD\" ]; then\n" | ||
| " KSUD=$(find /data/app -path '*/org.bakasu.bakasu*/lib/arm64/libksud.so' 2>/dev/null | head -1)\n" |
Match org.bakasu.bakasu-* so lookalike packages (e.g. org.bakasu.bakasu.evil) cannot be picked up and executed as root, same as the existing me.weishu.kernelsu-* lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BakaSU is the renamed ReSukiSU, so this adds org.bakasu.bakasu anywhere we look for a manager app (AndroidManifest.xml queries, prepareKsud package list, root script libksud.so fallback). Old ReSukiSU entries stay as-is.
BakaSU hasn't had a stable release yet (RC APKs still use the old package id), so this is just to be ready when it ships.