fix(stash): return top-level response fields - #66
Open
SajoLuo wants to merge 1 commit into
Open
Conversation
SajoLuo
marked this pull request as ready for review
July 22, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
status,headers, andbodyat the top level for Stash response scripts.responseoutput used by request-script-style clients.Why
Stash only accepts
responseas a request-script field used to synthesize a response. A response script must passstatus,headers, andbodydirectly to$done. The existing finalizer wrapped the patched WLOC response in{ response: ... }, so the script logged successful protobuf patches but Stash did not apply the modified response.Impact
Stash users receive the patched WLOC binary response instead of the original response being left in place. Other clients keep their existing output shape.
Related to #5, #44, and #45.
Validation
cd worker && npm test$donepayload has noresponsewrapper and retains status, headers, and binary body.