Skip to content

Broaden MyYoast connection rollout to 20% - #23490

Merged
pls78 merged 2 commits into
release/28.2from
broaden-myyoast-connection-rollout
Jul 27, 2026
Merged

Broaden MyYoast connection rollout to 20%#23490
pls78 merged 2 commits into
release/28.2from
broaden-myyoast-connection-rollout

Conversation

@diedexx

@diedexx diedexx commented Jul 23, 2026

Copy link
Copy Markdown
Member

Context

The MyYoast connection feature (OAuth client, WP-CLI commands, key-rotation cron) is gated behind the YOAST_SEO_MYYOAST_CONNECTION flag and additionally rolled out to a deterministic share of sites via Gradual_Rollout_Conditional. As the rollout has proven stable at 1%, this PR widens the share to 20% for the next release.

Summary

This PR can be summarized in the following changelog entry:

  • Increases the MyYoast connection rollout share from 1% to 20%.

Relevant technical choices:

  • The rollout share is expressed in per-mille (0–1000), so 20% is 200; the value was raised from 10 to 200 in MyYoast_Connection_Conditional::get_rollout_share().

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Because the rollout is deterministic per site, verifying an exact 20% share is not practical on a single install; confirm the value is 200 in src/conditionals/myyoast-connection-conditional.php and that a site opted into the flag still connects as before.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • Not applicable — this only changes the internal rollout percentage of a feature-flag-gated connection and has no directly observable user-facing behaviour.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The MyYoast connection (OAuth client, WP-CLI commands, key-rotation cron); more sites will be eligible for the connection than before.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and committed the results, if my PR introduces or edits images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Raises the gradual-rollout share for the MyYoast connection feature flag
from 1% to 20% (per-mille 10 -> 200) as the rollout widens.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@diedexx diedexx added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 23, 2026
The harness site URL buckets at 35; raising the share to 200 per-mille
(20%) puts it inside the cohort, so is_met() now returns true.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 0

Coverage at 51.998% (no base build to compare)

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (0 of 1 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/conditionals/myyoast-connection-conditional.php 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 43013
Covered Lines: 22366
Line Coverage: 52.0%
Coverage Strength: 4.21 hits per line

💛 - Coveralls

@diedexx
diedexx marked this pull request as ready for review July 24, 2026 08:49
@enricobattocchi enricobattocchi self-assigned this Jul 24, 2026

@enricobattocchi enricobattocchi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ok

@pls78 pls78 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acc: ✅

@pls78 pls78 added this to the 28.2 milestone Jul 27, 2026
@pls78
pls78 merged commit 9fc4b9c into release/28.2 Jul 27, 2026
28 checks passed
@pls78
pls78 deleted the broaden-myyoast-connection-rollout branch July 27, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog fix-before-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants