upstream pull#4
Draft
ivomink wants to merge 4236 commits into
Draft
Conversation
## Short description <!-- What do you propose to change with your PR? --> I think I accidentally removed the NanoMed Security from Bagel's Brigmedic during #4598 (oops) (sorry). This PR re-adds the NanoMed Security back to Bagel's Brigmedic. I also slightly reorganized the medkits, as I had to get rid of a table to make everything fit comfortably. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Fixes an oversight, and will be required for #4043 ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="1011" height="792" alt="image" src="https://github.com/user-attachments/assets/4374d930-d69b-4028-aca6-ba7743b2c60e" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - fix: (Bagel) The missing NanoMed Security has been re-added to Brigmedic.
## Short description - Adds fax groups with colors and predictable group ordering; - Adds fax ordering within their respective groups; - Adds mapping prototypes for fax machines: - Station fax prototypes are exhaustive; this way we can add mapping tests for this later on. - Event fax prototypes are non-exhaustive; they just provide a base fax that belongs to the group and can be edited from there to fit the event needs. - Adds new fax editing UI to not just rename, but also change the group and order number of the machine. Requires @CawsForConcern review, specifically for the fax prototypes. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> There's a few problems with the fax peer selection system currently: - It's just a very long list of randomly sorted fax machines. - Faxes for predictable places (e.g. the Captain's office) have inconsistent naming across maps (sometimes "Captain", "Captain's Office", "Captain office", you get the gist.) - "Special" faxes, such as MedTak fax machines during a MedTak event, get drowned out in this long list and have no way to stand out. This PR solves all of these problems. ## Long description - Adds `FaxGroup` prototypes that `FaxMachine`s can be assigned to. - Contains color, name and order number that determines the order the groups appear in. - Added fax group per on-station department. These are freely selectable. - Added fax groups for CC, Syndicate and Interstellar Trade Guild (who runs the ATS in our lore). These ones you cannot select when reconfiguring a fax machine, unless you emag it. - Upstream fax machine prototypes adjusted to fit in. - Group set, names and colors in the spawn menu adjusted. ### For mapping - Added an exhaustive list of fax machine prototypes. - Intent is to replace mapped fax machines with these in the coming time. Naturally in coordination with @CawsForConcern. - Eventually when we have sufficient coverage using them, we can start adding mapping tests to see if the expected fax machines are present on stations. ### For events - Added group prototypes: - Blackstar - MedTak - NTSF - TSF - USSP - Wizard - Added one fax per above event group. - They are all intrinsically bound to their respective group, meaning you can't switch it to be e.g. a Command fax machine, unless you emag it. - All marked `DO NOT MAP` meaning they aren't intended for regular stations. - All event groups have `1500` as their order, meaning they by default appear directly below the `Central Command` group. This is intentional to make it easy to find event faxes. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ### Fax prototypes Note: Colored in list for easier visual distinction. They are colored normal gray when placed. <img width="649" height="1270" alt="image" src="https://github.com/user-attachments/assets/fcaa5f8b-f10f-4e13-b82e-2b82ae2d8648" /> <img width="649" height="1122" alt="image" src="https://github.com/user-attachments/assets/8aa61e25-5170-4814-8365-5646e45071eb" /> ### Peer list https://github.com/user-attachments/assets/b8660732-3dd6-4f61-9130-95ece9ed1732 ### Configuring https://github.com/user-attachments/assets/dbbb7cdf-c7cd-4241-a382-3756516e82a3 ### Emagged peer list https://github.com/user-attachments/assets/27d734fb-20df-4424-b376-3fa4806d5ac3 ### Emagged configuring https://github.com/user-attachments/assets/93a99bbd-09a0-4263-8411-8c0c65d319b8 ### Locked to intrinsic group until emagged https://github.com/user-attachments/assets/a9e67a64-0156-41ae-a998-b62481e030ce ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. --> :cl: redmushie - add: Fax machine groups, colors and ordering! Faxes can now be sorted into departmental and faction groups, and are sorted for easier finding. (Pending mapping changes for a fuller rollout).
## Short description <!-- What do you propose to change with your PR? --> Two bugfixes - CMO had the CE's dresser mapped instead of the CMO's dresser. - The surgery crate in Surgery is empty. I've replaced it with the not-empty 'surgical supplies crate'. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Bugfixes! ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="672" height="444" alt="image" src="https://github.com/user-attachments/assets/49cfbf42-0e9c-4084-9fa7-39ab3f8e649d" /> fig. 1 - Fixed the dresser. <img width="523" height="446" alt="image" src="https://github.com/user-attachments/assets/74e7108d-5016-4685-9b9e-4f8f487f204f" /> fig. 2 - Fixed the surgery crate. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - fix: CMO accidentally had the CE's dresser instead of the CMO's dresser, now fixed. - fix: Replaced the empty surgery crate in Surgery with the not-empty 'surgical supplies crate'.
## Short description <!-- What do you propose to change with your PR? --> Replaces all the protogen sub species audio clips with recreated audio clips with a lighter robotic effect with no clipping issues. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> The current protogen sounds are loud and have clipping. I recreated the robotic effect with no clipping and made the robotic effect less aggressive, some clips were unrecognizable due to how heavy the effect was on the original sound clips. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. --> :cl: RenMeow1 - add: Replaced all protogen sub species audio clips. - tweak: Updated attributions files with updated details as the file were recreated and not the original protogen sub species audio clips. --------- Co-authored-by: Ren <ren@ren.blue>
## Short description Ports Wizden [#43057](space-wizards/space-station-14#43057) Notably, I've made a few minor adjustments to it, giving the medic a jet injector, since they exist now, and giving the thief some pretty lackluster (no strip time reduction) thieving gloves that can't be unequipped, so you have to actually work with them instead of just buying them for their stuff. Their thieving gloves are insulated though, to make up for them being unable to equip their combat gloves. Oh also, I gave the spy the voice mask implanter in their hand, since our chameleon backpack has the badge slot now. ## Why we need to add this The reasoning in the original post is pretty good, so I'll just paste it here: As per discussion with traitor workgroup, there was consensus that the reinforcements felt extremely underwhelming to use. They're all comically valid and require the buyer to go out of their way to collect items to prop up the reinforcement, which makes it feel more like an inconvenience to get one than the significantly less expensive but self-sufficient monkey / kobold. This also ignores that some (medic especially) were also really awful at doing their intended job. I was given the shot to rebalance these all in one go and I took a stab at reworking their kits to make them all feel more unique, specialized into their respective niche, and FUNCTIONAL in that niche. Thoughts on each individual specialization and their respective changes below. Medic was a reinforcement that basically had no current place. Outside of the basic reinforcement blueprint you got a combat medkit, and that was it. In raw TC value it fell short compared to the other options, and it completely lacked the pieces necessary for a traitor to actually avoid medbay, whether that be reviving an ally dragged away from a firefight or covering anything more than the most rudimentary damage. The goal of Medic for this rework was to make a reinforcement that felt very functional outside of the medbay, losing the viper, syndie backpack, and filled combat boots for a more dedicated support niche that doesn't really have tools to advance a traitor's goals but also can't be immediately killed and RR'd as a foreign invader. I noticed how similar the reinforcement medic's gear was to the (now-removed) doctor visitor and thought that it sounded like a perfectly flimsy but functional alibi for the reinforcement while giving a healthy supply of medicine to cover basically every instance of damage a traitor might get. Doctor visitor gear, a defibrillator, a pack of Interdynes, a health analyzer, a bottle of Bic pills and a few syringes and a bottle each of Toxin and Necrosol rounds out the loadout with a combat kit. The toxin and necrosol are easy removals if these seem out of place, but poison on a syndicate doctor felt like it could lead to interesting strategies / actions due to the slow TTK while also serving as a reminder that YOU ARE EVIL to the reinforcement and to maybe not get too into being a good doctor. The necrosol serves to save any syndicate that find themselves either horribly maimed or RR'd by poison. Omnizine felt like too much, this was the middle ground. Again, easy removals but could be used creatively or with more investment by the purchaser, and worth discussing. Spy was nearly there but just had a lot of outdated equipment due to the equipment rebalance. In exchange for losing the syndie backpack and the filled combat boots, the voice mask was updated to instead be the voice mask implanter, and the agent ID was replaced with a filled chameleon backpack (syndicate version, so also has an ID). This is a net loss in terms of TC value but should feel way, way more functional as a reinforcement that can immediately back you up and act in a bunch of creative ways. Thief is in a weird place because syndicate objectives don't really fit pure thieving; breaking and entering without any obfuscation like a chameleon kit is more an immediate loud thing because you need to kill a guy or steal something (off a corpse). On paper the TC value of the thief kit is actually pretty great, being functionally cheaper than a monkey by a large margin (backpack + viper + jaws + susbox is, functionally, 9tc plus a free syndie gasmask on top!!) but the unpopularity of the choice and the evident, massive downsides of a lack of disguise show that this option clearly isn't effective despite the sheer value. The way I decided to improve on this specialization was to lean even further into a hybridized loud / steal function. The Thief gets an additional viper mag and a camera bug, to help with planning breaking into a department to assassinate a target or making sure the coast is clear before sneaking in some place they shouldn't be. Compared to other specializations you get big TC value but are also way less able to traverse the station and way more reliant on support, which either forces your purchaser to go out of their way to cover these weaknesses / buy solutions, or accept the downsides and work more aggressively with the reinforcement. Ultimately the vision was to make each reinforcement good in specific but generic scenarios. Examples of the kind of things I was aiming for below: - I'm working with another traitor and they get shot / killed / executed, but I'm able to pull their body into maints and hide. A medical reinforcement is able to get them on their feet and continue helping us after the fact, so it feels like a great option. - I complete my objectives without using much TC and am waiting for evac. A medical reinforcement is suspicious but protected by space law, will help me stay alive, and may have fun objectives to give me something to do, so it feels like a decent thing to buy instead of hoarding TC doing nothing. - I want a reinforcement that can just help me with what I'm working on immediately without having to spend a lot of time getting it up to speed while also wanting more capability than a monkey / kobold, a Spy seems good. - I want to give my reinforcement my second objective while I work on my plan alone for my first. Spy would be great. - I am ready to commit to killing my target but am not confident on doing it by myself. The Thief is great, because I get another pair of hands to help and can better time the right moment to break in. - I want value and I'm willing to spend time to prop up a reinforcement. Thief gives great value and are items that would be helpful for what I'm trying to do, so Thief seems great. - I want to go loud. Medical could be nice because we get plenty of healing value. Spy could be nice to make use of the IDs and accesses we get. Thief gives me plenty of tools to do so, if I'm willing to work around how valid they are. ## Media (Video/Screenshots) <img width="330" height="258" alt="image" src="https://github.com/user-attachments/assets/e17be7c0-edc1-4df9-b4f7-c044e228734c" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld, Princess-Cheeseballs - tweak: Rebalanced the syndicate reinforcement specializations to be more effective at their roles. --------- Co-authored-by: 0-Anon <cec124@case.edu>
…on 1.1 (#4675) ## Short description Second attempt at getting this looked at. Adds a brand new plant to botany, the Resinfera, able to be grinded into Acrileni, a brand new chem that, when combined with Bruizine and Razorium, mixes into Briomadine, a brute chem that is twice as effective as Bicaridine. Changes from version 1: Briomadine and other brute chems can no longer be used together, Briomadine will now mix with other brute chems to create Ipecac. ## Why we need to add this https://discord.com/channels/1272545509562777621/1506839351940878496 I went into greater detail within my suggestion post but, in short. Botany, despite being able to create chems that are more effective than what chem can make alone, is often undervalued or ignored by chemists. I believe this is because all the chems that botany can create or help in creating, are for rarer damage types. Stellibinin for example, is more effective at healing poison than even Diphen, but an additional 10 healed poison does not have enough impact for semi-skilled chemists to give it much attention. This is my first change in the pursuit of fixing this and allowing botany to have more of an impact on station. Adding a chem that is significantly greater than its counterpart but requiring a sufficiently skilled botanist to make it in great amounts. ## Media (Video/Screenshots) <img width="531" height="476" alt="image" src="https://github.com/user-attachments/assets/1dd99946-0a21-40eb-9138-14fa0bc76d77" /> <img width="518" height="287" alt="image" src="https://github.com/user-attachments/assets/cca4672d-d8b5-48e8-8c62-3f3aa03f773d" /> <img width="198" height="85" alt="image" src="https://github.com/user-attachments/assets/44a32bc1-c7dd-441b-bde6-a39cae321523" /> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Musiklie - add: Added Resinfera, a new botany plant, can be grinded down into Acrileni. - add: Added Acrileni, a new chem that can be mixed with Razorium and Bruizine into Briomadine. - add: Added Briomadine, A greater brute chem, twice as effective as Bicaridine with a lesser consequence if mixed with other brutes.
## Short description <!-- What do you propose to change with your PR? --> My grand return to spess station. I present the admins with a QOL change. Adds a configuration option in the admin tab that allows you to set a path (relative to the data folder of the launcher) to a script to execute when becoming an admin observer. Saved as a client cvar named `admin.admin_ghost_script_path`. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Convenience. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="178" height="67" alt="image" src="https://github.com/user-attachments/assets/e108385e-be94-48da-8248-8c42a036bd88" /> https://github.com/user-attachments/assets/88d98bb5-d8b3-4f7a-8b7b-02c9a64573c2 https://github.com/user-attachments/assets/6f4329eb-fad7-4aa5-b6c9-e0f3f33a2435 ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Add a Senior Jacket and Jumpsuit for the Chef role. ## Why we need to add this To add a reward to those who spent 60 hours playing Chef and providing RP and food to the rest of the crew. ## Media (Video/Screenshots) <img width="329" height="305" alt="image" src="https://github.com/user-attachments/assets/e92b5df6-0f76-47a2-95f8-fc9f22506414" /> <img width="267" height="283" alt="image" src="https://github.com/user-attachments/assets/2b72bf6a-364b-438d-8a7b-243309c2e16b" /> <img width="244" height="317" alt="image" src="https://github.com/user-attachments/assets/a74963c1-270d-413b-900e-92c245dce5fd" /> <img width="249" height="276" alt="image" src="https://github.com/user-attachments/assets/d37e0010-e5dd-405b-8645-c29c14a8fa93" /> <img width="787" height="452" alt="image" src="https://github.com/user-attachments/assets/83e0be98-b84a-4d30-b842-b699e2b89c7e" /> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Kasern - add: Senior Chef Jacket. - add: Senior Chef Jumpsuit. - add: Senior Chef loadout options. --------- Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
## Short description <!-- What do you propose to change with your PR? --> Gives all Service jobs the `Service` access. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> For some reason, Service is the only department where not all jobs have the access that corresponds to.. well, their department. This is horribly confusing and basically makes `Service` useless for the purposes of restricting something to the Service department. Every other department has an access level for department-wide access, except Service apparently. Turns out there's consequences of this too. The service request console for example was limited to `Service` and `Theater`, but Chaplain has neither of those and has just been unable to use it **this entire time**. Per my tamper seal PR, it also came to my attention that the four affected jobs couldn't open those, so this fixes that too. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> | Job | Before | After | |-|-|-| | Botanist | ✔️ | ✔️ | | Chaplain | ❌ | ✔️ | | Chef | ✔️ | ✔️ | | Clown | ❌ | ✔️ | | Janitor | ✔️ | ✔️ | | Lawyer | ✔️ | ✔️ | | Librarian | ✔️ | ✔️ | | Mime | ❌ | ✔️ | | Musician | ❌ | ✔️ | As an example, Chaplain ID card now having Service access: <img width="860" height="715" alt="image" src="https://github.com/user-attachments/assets/3e52caef-ac24-4143-a3d9-c247ff2cc3a0" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. --> :cl: redmushie - tweak: All Service jobs now have Service access. Chaplain, Clown, Mime and Musician did not have it previously. - tweak: The service request console now only uses Service access.
## Short description Ports space-wizards/space-station-14#43039 / Space-Wizards-Federation/space-station-14#52, they're the same PR. It fixes a bug where dynamic rule didn't create roundstart antagonists, and then I went in and added in the rest of our major gamemodes and tweaked Dynamic. Should only be run by event/admins, since it's physically impossible to test Dynamic locally due to the player count requirement. I want to run this on Delta/Alpha through planned events to get a scope of how the gamemode functions. ## Why we need to add this Bugs are bad. Dynamic rules are cool. ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld, Golub - add: Added Cosmic Cult, Wizard Duel, Xenoborgs, Terror Spiders, Vampires, Changelings, SELF, Sub Wizards, and Paradox Crisis to Dynamic. - add: Added a higher ceiling to Dynamic's roundstart budget. - tweak: Tweaked Dynamic weights. - fix: Dynamic will now actually select roundstart antagonists.
## Short description Fix request computers not checking access. ## Why we need to add this They have access readers. They don't do anything. Anyone can print orders on any console they happen to be near. That's not great. They can spend funds of departments they don't belong to. The most egregious example is the service request computer as that one is typically mapped in public areas. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> https://github.com/user-attachments/assets/22cfce27-5a38-481c-8ad4-6e5a4f817c91 ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: redmushie - fix: Request computers actually check access now.
## Short description This PR does three things primarily: - Switches shard filters being passed to the test runtime from CLI argument to `.runsettings` file - Adds `prepare_test_shards.py` to locally generate the shards easily - Adds Rider run configurations for said script, plus for the 8 shards Some small other changes like renaming the sharding script and moving it to the _Starlight subfolder in `Tools/` ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Actually gives us a way to locally run specific shards instead of e.g. manually copying the filter string. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="934" height="793" alt="image" src="https://github.com/user-attachments/assets/bfed271e-9fe4-4ee3-bd08-8dce05b675c3" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
## Short description Give functionality for some windows to be able to be popped out. Windows that can be popped out: Guidebook Admin Logs Crew Monitors Mass scanners Shuttle Consoles Camera Monitors AI Station records Ghost Character Editor ## Why we need to add this QOL https://discord.com/channels/1272545509562777621/1517556981035172042 ## Media (Video/Screenshots) https://github.com/user-attachments/assets/4648fe97-95f8-4989-b76c-b598a62efb74 ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. --> :cl: Mack - add: Popout to: Guidebook, Crew Monitors, Mass Scanners, Shuttle Consoles, Camera Monitors, AI Station records, Ghost Character Editor.
## Short description Fix issue where ID card job names were not being escaped on radio. ## Media (Video/Screenshots) <img width="504" height="319" alt="dotnet_10D5kfNBne" src="https://github.com/user-attachments/assets/08e66050-3f51-4dac-94b4-9160b347eafb" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Mack - fix: ID job names not being escaped. --------- Co-authored-by: Rinary <rinary.super@gmail.com> Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
…#4914) ## Short description <!-- What do you propose to change with your PR? --> **This PR doesn't change any mechanics, it is strictly visual.** We inherited an upstream change to security jetpacks from: space-wizards/space-station-14#39569 That PR has issues: - It changed the name of `JetpackSecurity` to "security mini jetpack" but _didn't_ change the name of `JetpackSecurityFilled` which is still "security jetpack" - It didn't change the sprites of the security jetpack This makes the security jetpack super confusing, because it looks like a full-size jetpack but it _is_ a mini jetpack, meaning it can go in your suit storage or in your belt slot. This PR: - Changes the name of `JetpackSecurityFilled` to match `JetpackSecurity`: "security mini jetpack" - Adds new sprites to make it obvious that the jetpack is a mini jetpack. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> - Naming consistency is good - Visual clarity (via new sprites) is good ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="924" height="733" alt="image" src="https://github.com/user-attachments/assets/77c4ef0f-ef9b-43d4-8e71-866a27a69514" /> fig. 1 - New security mini jetpack sprites <img width="148" height="76" alt="animation in gui" src="https://github.com/user-attachments/assets/a3e8cf7d-9fb8-43dd-9208-2c48823b7325" /> fig. 2 - Animation in GUI <img width="344" height="166" alt="image" src="https://github.com/user-attachments/assets/f7b9b305-2b77-4742-b041-bf4251cd7a33" /> <img width="493" height="272" alt="image" src="https://github.com/user-attachments/assets/ffd9e7f8-f291-415a-acf1-d927ea48f005" /> fig. 3 - Fixed name. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - add: Added new sprites for the Security mini jetpack to make it more obvious it's a mini jetpack (and not a full-size jetpack). - fix: Fixed the name of the security mini jetpack. Previously, it was "security jetpack" if it spawned full of gas and "security mini jetpack" if it spawned empty.
## Short description <!-- What do you propose to change with your PR? --> Allows requesting an immediate system rejoin in `AtmosDeviceComponent`. Because apparently making things VV responsive is """bad""", you either have to use a trick verb or run `atmos:rejoin` to make the atmos device attach to the grid's atmosphere without dragging it off the grid and back on again. Also adds `atmos:fix` as a TSH implementation of `fixgridatmos` because why not, may as well. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Admemes, convenience, etc. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. --------- Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
## Short description Adds a basketball ring to an otherwise unused area for people to enjoy, and other fixes. ## Why we need to add this More things to do and places to RP in at end of round. ## Media (Video/Screenshots) <img width="742" height="440" alt="image" src="https://github.com/user-attachments/assets/f7411331-d53c-4a41-8fe8-7cd7fd00e029" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Johnny - add: (CC-SC17) Added a basketbool ring to an unused area west of science. - tweak: (CC-SC17) Tweaked a few items using VV. - fix: (CC-SC17) Fixed the arcade not having power.
## Short description <!-- What do you propose to change with your PR? --> Yet another nuclear reactor and small engie maints expansion. Plus the chore work of the 2026 mapping rollcall. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Nuclear reactor is a fun engine! ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="1372" height="695" alt="image" src="https://github.com/user-attachments/assets/7bbe160d-ad19-477f-aff8-320a93172511" /> <img width="1162" height="802" alt="image" src="https://github.com/user-attachments/assets/fa0ef76f-9d44-46d4-bad6-4d806b05a4b0" /> <img width="1031" height="571" alt="image" src="https://github.com/user-attachments/assets/0d91d198-1ff4-411f-9e3a-9b601a311308" /> <img width="714" height="581" alt="image" src="https://github.com/user-attachments/assets/1efbca5d-23b1-4f12-8826-13f6ac633fad" /> <img width="904" height="816" alt="image" src="https://github.com/user-attachments/assets/321d9802-2337-4d9b-8e7a-2625804e494a" /> <img width="607" height="685" alt="image" src="https://github.com/user-attachments/assets/21d01757-6471-4d61-ae83-45e88076aab4" /> <img width="578" height="482" alt="image" src="https://github.com/user-attachments/assets/ceafde06-7850-4700-8c75-223e3331cfbd" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Cvlancer - add: (OASIS) Added nuclear reactor. - add: (OASIS) Added a new maints location "Crystal Cove" to engie maints. - add: (OASIS) Added escape pod station beacons. - add: (OASIS) Added shipyard console. - add: (OASIS) Added the new fax machines. - add: (OASIS) Added kiki and two more hydro trays. - add: (OASIS) Added new maints location below nuclear reactor. - add: (OASIS) Added a remote signaler to maints shop. - add: (OASIS) Added several air vents to engie maints. - add: (OASIS) Added extra room to the secret syndicate room. - add: (OASIS) Added robotics locker to robotics. - add: (OASIS) Added virology locker to viro. - add: (OASIS) Added surgeon closet to surgery. - add: (OASIS) Added coroner locker to morgue. - add: (OASIS) Added a wrench to drugstore. - add: (OASIS) Added a ghost to gen pop mine. - remove: (OASIS) Removed one mid round spawn botanist. (Now its 2 at shift start plus kiki). - fix: (OASIS) Fixed tiles under maints shop, security. - fix: (OASIS) Fixed security dispo pipes.
## Short description Adding vox lungs as a buyable option in the med vend ## Why we need to add this It allows people to optionally debuff themselves incase they ever lose their lungs. Im not sure but yeah lotta people want it. https://discord.com/channels/1272545509562777621/1519585875736920124 ## Media (Video/Screenshots) <img width="388" height="109" alt="image" src="https://github.com/user-attachments/assets/8fc1883a-7ace-4680-93fe-ebe706fca843" /> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Johnny - add: Added vox lungs in med vend cuz people want it.
## Short description <!-- What do you propose to change with your PR? --> - Fix username required to match (he uses Discord auth now) - Fix left/right directions being reversed ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> <img width="682" height="442" alt="image" src="https://github.com/user-attachments/assets/32a7b59f-bb44-4cd7-93c3-561f522ff293" /> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Nah ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description <!-- What do you propose to change with your PR? --> - Update vampire ability descriptions to be... less descriptive! - Blood cost in name uses same formatting. - Remove any (Free) or (0) in favor of just the ability name. Side note on blood cost in the name: I will raise a enhancement for: Dynamically use the cost of ability in the name of ability so we don't need to keep the costs up to date in the name. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> The vampire ability descriptions give precise exact detail about what was going on. For example: > Remove stuns and knockdown, reset stamina, purge up to 10u of poisons, then heal 20 brute, 20 burn, 20 poison, and 25 asphyxiation over This encourages min maxing numbers, brings you out the game in a meta sense. This PR rewords the descriptions to be less precise but still give the player an understanding of what is going to happen when ability is used. > Removes any and all stuns, restores stamina. Purges poisons and heals you over time. i did this while looking at this bug report: #4016 ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Not required because its only descriptions being changed. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Toxyams - tweak: Vampire ability descriptions. --------- Co-authored-by: Rinary <rinary.super@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
## Short description Ports space-wizards/space-station-14#43161 and space-wizards/space-station-14#43444 from Old Wizden. A large number of our files needed corrections to swap to the new User / EquipTarget naming for event fields. ## Why we need to add this T-Ray modes enable engineers to pick through the mess of overlaid wires and pipes on stations for troubleshooting much easier. FleetingClothingComponent refactoring was required for this also, and we needed it anyway. **Breaking Changes for Downstreams:** Renamed some event fields to make them consistent with other events: Renamed `BeingEquippedAttemptEvent.Equipee` to `User` Renamed `IsEquippingAttemptEvent.Equipee` to `User` Renamed `BeingUnequippedAttemptEvent.Equipee` to `User` Renamed `IsUnequippingAttemptEvent.Equipee` to `User` Renamed `DidEquipEvent.Equipee` to `EquipTarget` Renamed `GotEquippedEvent.Equipee` to `EquipTarget` Renamed `DidUnquipEvent.Equipee` to `EquipTarget` Renamed `GotUnequippedEvent.Equipee` to `EquipTarget` ## Media (Video/Screenshots) https://github.com/user-attachments/assets/180aadb6-4b89-47dd-9861-2a4824abe44b ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Psykana, Slarticodefast, Conflee - add: Added T-Ray Scanner Modes, allowing you to toggle between showing All, Pipes, and Wires. - tweak: Changed event field naming as part of a refactor. All Upstream and current Starlight Repo files are corrected, however Downstreams of SL may need to confirm and swap their use of Equipee to the correct event field names. --------- Co-authored-by: psykana <36602558+psykana@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
## Short description Ports the remainder of Wizden [#42977](space-wizards/space-station-14#42977), which is required for [GameTest part 2](space-wizards/space-station-14#43207). ## Why we need to add this It's becoming apparent that I might not be able to finish porting GameTest part 2 myself, due to the complexity of it, so, out of not causing confusion for whoever tries after me, or if I manage to figure it out a bit more in the future, I figured I should clear up this loose end I didn't get to in the [prior PR](#4674). ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. No CL nothing player facing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
LICENSE: BSD-2-Clause
Why we need to add this
Media (Video/Screenshots)
Checks
Changelog
🆑