add contributor information to readme.md#225
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new contributor entry to the README’s contributors table and tweaks the repository’s VS Code workspace color customization settings.
Changes:
- Added a new contributor row (GitHub + LinkedIn links) to
readme.md. - Removed several
workbench.colorCustomizationskeys from.vscode/settings.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| readme.md | Adds a new contributor block in the contributors HTML table. |
| .vscode/settings.json | Adjusts VS Code color customization settings by removing some entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
readme.md
Outdated
| </table> | ||
| </td> | ||
| </tr> | ||
| <!-- //Mohamad Bashir // --> |
There was a problem hiding this comment.
Closing contributor marker uses <!-- //... // --> with extra spaces, while adjacent entries use <!--// Name //-->. Please keep the marker style consistent with the rest of the table.
.vscode/settings.json
Outdated
| "statusBarItem.remoteBackground": "#C6FF00", | ||
| "activityBar.activeBorder": "#C6FF00", | ||
| "tab.activeBorder": "#C6FF00" | ||
| }, | ||
| "activityBar.background": "#382742", | ||
| "titleBar.activeBackground": "#4E375C", | ||
| "titleBar.activeForeground": "#FBF9FC" | ||
| } |
There was a problem hiding this comment.
PR description says "I added my name", but this hunk also changes repo-wide VS Code color customization settings. Either update the PR description to mention the settings change (and why it's needed), or drop this change so the PR scope matches its description.
readme.md
Outdated
| <!-- //Mohamad Bashir // --> | ||
| <tr> | ||
| <td align="center" width="600"> |
There was a problem hiding this comment.
The surrounding contributor markers use the format <!--// Name //--> (no extra spaces). These new markers include extra spaces (<!-- //... // -->), which makes the table harder to scan/grep consistently. Please match the existing marker style, and align indentation of the <tr> with neighboring entries.
moh-bash
changed the title
I added my name