Repository navigation
Engine accuracy (M0): scoring v2, unique finding IDs, patch table, OS role - #1
Open
XpertLambda wants to merge 3 commits into
Open
XpertLambda wants to merge 3 commits into
XpertLambda wants to merge 3 commits into
Conversation
…ble, OS role - Rating is the worst effective severity tier and the score stays inside that tier's band; 1.8.0 summed counts and reported "Critical, 100" for a host with no Critical finding. Low-confidence findings count one tier lower. - Patch hints apply only to the builds that existed before each fix and only to the right role (Zerologon on domain controllers); one low-confidence finding per CVE. Windows 11 25H2 no longer gets six 2020-2022 findings. - Finding IDs: rule + instance_key, unique per scan (engine safety net), no machine name in event-log IDs, non-ASCII encoded instead of dropped; 1.8.0 baselines still compare. - OS name from product type (Server 2025 is not Windows 11); system_info gains os_name/os_family/os_build/os_ubr. - The same fact reported by two modules (UAC disabled) is merged. - ISO-8601 UTC time and schema_version in the JSON report. - Tests: scoring (reference values + property test), identity, patch table, OS classification, timestamps; Windows smoke assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the confirmed engine bugs from a scan of a fresh Windows 11 25H2 image.
Changes
summary.scoring.model_versionis 2.rule#instanceIDs, unique per scan (engine safety net + warning), no machine name in event-log IDs, non-ASCII encoded instead of dropped. 1.8.0 baselines still compare.system_infogainsos_name,os_family,os_build,os_ubr.scan_info.generated_utc,utc_offset_minutes,schema_version.Compatibility
Scripts that read
ratingorrisk_scorewill see different values. Event-log account findings have new IDs, so an old baseline shows them once as resolved plus new. See the CHANGELOG entry.Testing
-Werroris clean; a Wine run produced the expected JSON.tests/windows/smoke-test.ps1(unique IDs, rating/score consistency, host role, no stale patch findings on modern builds, single UAC finding) have not been run yet: this PR is their first run in CI.To verify
The build ranges in the CVE table come from release history and should be checked before relying on the exact cut-offs.