account.spec.ts: mask the live "Created" timestamp causing CI flake - #116
Merged
Merged
Conversation
…screenshot The Theme CI workflow started failing on main after PR #115 merged: the new mobile-390/iphone-393 account-signing-in.png baselines (generated locally) bake in the password credential's real "Created <timestamp>" line, which reflects whenever that realm/user was actually provisioned -- different every CI run against the disposable Keycloak fixture, and different again from whatever moment the baseline itself was captured. CI failed with an ~8000-pixel diff, entirely the timestamp string's own length/wrap shifting the layout after it. Mask [data-testrole="created-at"] instead of asserting on it -- its exact value was never what this screenshot exists to verify. Regenerated all six masked baselines against a fresh disposable Keycloak.
…90/iphone-393 The mask fix alone wasn't enough -- CI still failed with an ~8000-pixel diff, but this time every glyph on the page showed as different in the diff overlay, not just the (now-masked) timestamp region: my local sandbox's font rendering doesn't produce pixel-identical text to GitHub Actions' own Ubuntu runner, even for the same font files. A baseline captured locally can never match CI's render for a text-heavy page like this one. Pulled the actual CI-rendered screenshots straight from the failed run's playwright-report artifact (run 31856507193) and committed those as the baseline instead of re-capturing locally. tablet-820/uhq-1920/uhd-3840's signing-in baselines and every Applications baseline weren't flagged by either CI run, so they're left alone -- this environment mismatch apparently doesn't cross the 2% diff threshold for those, just this particular text-dense page at these two narrower widths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainafter account.spec.ts narrow-viewport coverage + a11y fix (#113), login.spec.ts hover/focus/disabled/loading coverage (#114) #115 merged: the new mobile-390/iphone-393account-signing-in.pngbaselines (generated locally) bake in the password credential's real "Created <timestamp>" line -- different every CI run against the disposable Keycloak fixture, and different again from whatever moment the baseline itself was captured. CI failed with an ~8000-pixel diff.toHaveScreenshotnow masks[data-testrole="created-at"]instead of asserting on it. All six baselines regenerated against a fresh disposable Keycloak.Fixes the CI failures on https://github.com/Xore/auth-backend/actions/runs/31855102728 and the equivalent push-to-main run.
Test plan
Signing inacross all 6 projects against a freshly reset Keycloak (docker compose down -v && up, matching CI's own disposable-instance behavior) -- all pass.