Skip to content

fix(ghidra): raise pinned benchmark output_tokens 512 -> 4096 (#1804 follow-up) #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xore merged 1 commit into from
Sep 25, 2026
Merged

fix(ghidra): raise pinned benchmark output_tokens 512 -> 4096 (#1804 follow-up) #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions analysis/ghidra/models/approved-models.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"concurrency": 1,
"context_tokens": 32768,
"keep_alive": "10m",
"output_tokens": 512,
"output_tokens": 4096,
"seed": 144,
"temperature": 0,
"thinking": false
Expand All @@ -77,7 +77,7 @@
"concurrency": 1,
"context_tokens": 32768,
"keep_alive": "30m",
"output_tokens": 512,
"output_tokens": 4096,
"seed": 144,
"temperature": 0,
"thinking": false
Expand Down Expand Up @@ -123,7 +123,7 @@
"concurrency": 1,
"context_tokens": 8192,
"keep_alive": "10m",
"output_tokens": 512,
"output_tokens": 4096,
"seed": 144,
"temperature": 0,
"thinking": false
Expand Down
2 changes: 1 addition & 1 deletion analysis/ghidra/worker/ghidra-worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def _reassert_dir_perms(path: Path) -> None:
"GHIDRA_TRIAGE_API_BASE", "http://127.0.0.1:11434/v1").rstrip("/")
TRIAGE_MODEL = os.environ.get("GHIDRA_TRIAGE_MODEL", "qwen3:14b")
TRIAGE_TIMEOUT = int(os.environ.get("GHIDRA_TRIAGE_TIMEOUT", "300"))
TRIAGE_OUTPUT_TOKENS = int(os.environ.get("GHIDRA_TRIAGE_OUTPUT_TOKENS", "512"))
TRIAGE_OUTPUT_TOKENS = int(os.environ.get("GHIDRA_TRIAGE_OUTPUT_TOKENS", "4096"))
TRIAGE_SEED = int(os.environ.get("GHIDRA_TRIAGE_SEED", "144"))

# #2646: temperature 0 and a fixed seed do not make two runs agree. Ollama
Expand Down
2 changes: 1 addition & 1 deletion analysis/ghidra/worker/tests/test_ghidra_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ def test_triage(ghidra, model, truncating):
"the system prompt names the evidence as untrusted")
check(all(p.get("reasoning_effort") == "none" for p in ModelStub.prompts),
"bounded triage disables hidden reasoning")
check(all(p.get("max_tokens") == 512 for p in ModelStub.prompts),
check(all(p.get("max_tokens") == 4096 for p in ModelStub.prompts),
"the approved output cap is sent to the model")
check(all(p.get("seed") == 144 for p in ModelStub.prompts),
"the approved deterministic seed is sent to the model")
Expand Down
Loading