Skip to content

fix(dicompot): close 3 DICOM association fingerprint tells (#3155) - #3181

Merged
Xore merged 1 commit into
mainfrom
issue-3155-dicompot
Sep 13, 2026
Merged

Xore merged 1 commit into
mainfrom
issue-3155-dicompot

Conversation

@Xore

@Xore Xore commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Persona Implementation Class UID now returned in A-ASSOCIATE-AC.
Max PDU Length fixed at persona constant 16384, never mirrored from peer.
A-ASSOCIATE-RJ on unrecognized Called AE title and A-ABORT on malformed first PDU.

Closes #3155

Persona Implementation Class UID now returned in A-ASSOCIATE-AC.
Max PDU Length fixed at persona constant 16384, never mirrored from peer.
A-ASSOCIATE-RJ on unrecognized Called AE title and A-ABORT on malformed first PDU.

Closes #3155
@strix-security

strix-security Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Updated for 78f486e.


Reviewed by Strix
Re-run review · Configure security review settings

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@strix-security strix-security Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all six changed files: the core logic in aetitle.go, the handleConn wiring in main.go, the test updates, and two documentation edits. The PR hardens the dicompot DICOM honeypot's protocol fidelity by (1) adding persona-consistent Implementation Class UID/Version Name and a fixed 16384 Max PDU Length to the A-ASSOCIATE-AC, (2) rejecting unrecognized Called AE Titles with a proper A-ASSOCIATE-RJ, and (3) answering malformed first PDUs with an A-ABORT. The buffer peek is deadline-bounded and safely indexed only after a successful 42-byte read; PDU patching operates exclusively on the honeypot's own generated responses with fail-closed fallback to forwarding original bytes; fixed response PDUs present no amplification vector; and the new log events reuse the existing JSON-encoded event struct with no new injection surface. No security control was removed and no untrusted input reaches a dangerous sink in the changed code. No findings to report.


Reviewed by Strix
Configure security review settings

@Xore
Xore merged commit d55f8b2 into main Sep 13, 2026
110 checks passed
@Xore
Xore deleted the issue-3155-dicompot branch September 13, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hp-dicompot: DICOM association fingerprint tells — one A-ASSOCIATE reveals the decoy (5 findings, sensor-fidelity)

1 participant