fix(arkime): node-scope capture healthcheck so a quiet network cannot trip autoheal; pcap-sync heartbeat without kill-loop on backlog (#3170) - #3176
Merged
Conversation
Global monotonic index counter tripped capture's healthcheck on a quiet network segment (no new traffic != stuck). Scope check to this node and fail open on ES errors so a bystander ES hiccup cannot restart capture. pcap-sync loop had no liveness signal: seed heartbeat before the first pass and touch it per-file (not per-pass), so a long pass over the live backlog never reads as wedged. Also fixes zero-byte staging. Closes #3170
Strix Security ReviewSecurity review could not be completed for this commit. Updated for Reviewed by Strix |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Capture healthcheck used a global monotonic index counter -- a quiet network segment (no new traffic) read as "stuck" and tripped autoheal, restarting a healthy capture process. Fixed by scoping the check to this node and failing open (exit 0) when ES itself is unreachable or the response can't be parsed, since an ES hiccup is a bystander, not a capture fault.
pcap-sync had no liveness signal at all: a long pass over the live 33 GB backlog looked identical to a wedged loop. Added a heartbeat file, seeded before the first pass and touched per-file (not per-pass), so a slow-but-alive sync never gets killed mid-backlog. Also fixes a zero-byte staging file left behind on interrupted copies.
Evidence
Closes #3170