Skip to content

fix(ops): allowlist deliberately-absent llm-worker in compose-drift sweep (#3129) - #3165

Merged
Xore merged 1 commit into
mainfrom
agent/issue-3129-coder
Sep 10, 2026
Merged

Xore merged 1 commit into
mainfrom
agent/issue-3129-coder

Conversation

@Xore

@Xore Xore commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Why

llm-worker is operator-gated down per #3023 for the #1947 cold benchmark run. The #3040 rule correctly alarms on a missing expected-persistent service even with no siblings to compare against — that's the exact shape that let llm-worker sit invisible for 11h. But #3040 gave no way to mark a known, reasoned absence, so it re-fires on the same intentional state (this PR closes #3129's re-fire).

Adds EXPECTED_ABSENT_WHILE allowlist (name → reason string citing #3023), checked in sweep() Gate 1. This implements the mechanism #3040 itself asked for, not a blanket sibling-suppression — every other missing-service case still alarms.

Evidence

Refs #3129

🤖 Generated with Claude Code

…weep (#3129)

llm-worker is operator-gated down per #3023 for the #1947 cold benchmark
run. The #3040 rule correctly alarms on a missing expected-persistent
service even with no siblings to compare against, but that leaves no way
to mark a known, reasoned absence. This adds an explicit
allowlist-with-reason (EXPECTED_ABSENT_WHILE), checked in sweep() Gate 1,
implementing the mechanism #3040 itself asked for rather than a blanket
sibling-suppression.

Refs #3129
@strix-security

strix-security Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Updated for dcf56f6.


Reviewed by Strix
Re-run review · Configure security review settings

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@strix-security strix-security Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the two changed files in full. The PR adds an EXPECTED_ABSENT_WHILE allowlist (keyed by project name with a documented reason) to the internal compose-drift-watch.py monitoring script, plus a Gate 1 check that skips alarming for the single named llm-worker project, and three corresponding unit tests. The allowlist key is a hardcoded string and the check performs a plain membership test on a directory name; no attacker-controlled input reaches any dangerous sink, and there are no secrets, auth, crypto, or injection changes. Bandit and semgrep found no issues in the changed lines (Bandit's low-severity subprocess notes are all pre-existing code outside the diff). The alarm-suppression is an explicitly documented, temporary operator decision and does not weaken access controls or expose data. No security vulnerabilities found.


Reviewed by Strix
Configure security review settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ops: 1 compose service(s) drifted out of existence (#2747 watch)

1 participant