ops(branding): point PDF assets at the Rust report composer (#2220) - #2691
Merged
Merged
Conversation
Issue #2220: branding/scripts/export_brand_assets.py still pointed at arcane/home/honeypot-dashboard/dashboard/ (the Go tree removed after the #1502 migration). The PDF asset write went nowhere and the favicon masters had been moved to a different location. This commit: - Drops the dead DASHBOARD_STATIC path (the favicon masters are now read directly from branding/assets/favicon). - Points PDF_ASSETS at the Rust report composer (arcane/home/honeypot-dashboard/backend-service/assets_pdf) where the masks are actually consumed via include_bytes!(). The script now writes to a path that the deployed Rust report composer reads, and the favicon export no longer assumes a tree that no longer exists. Closes #2220
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #2220: branding/scripts/export_brand_assets.py still pointed
at arcane/home/honeypot-dashboard/dashboard/ (the Go tree removed
after the #1502 migration). The PDF asset write went nowhere and
the favicon masters had been moved.
Changes
branding/scripts/export_brand_assets.py:DASHBOARD_STATICpath (the favicon masters arenow read directly from branding/assets/favicon).
PDF_ASSETSat the Rust report composer(arcane/home/honeypot-dashboard/backend-service/assets_pdf)
where the masks are actually consumed via include_bytes!().
Verification
.orchestrator/gate.sh HEAD all) passes (GATE_FAIL=0).Related
Closes #2220