Repository navigation
feat: support native Gemini GenerateContent - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateContent,countTokens, and transactional SSEstreamGenerateContent?alt=sse, including standard Vertex AI project/location paths.PROXY_GEMINI_BUFFER_MSconfiguration (default 600000 ms), Google-shaped errors, API-key archive redaction, regression coverage, and setup/operations documentation.thinkingLevelvalues in access and retry logs, accepting camelCase and snake_case fields. Do not infer levels from token budgets or model defaults.Reliability fixes
X-Should-Retry.client_gonefailures across Gemini, Responses, and Messages.google.rpc.RetryInfo.retryDelayfor HTTP and in-band SSE errors when no valid positive HTTPRetry-Afterexists. Round fractional seconds up and prevent long delays from overflowing local retry/deadline arithmetic.Codex CLI review
codex review --uncommittedtwice; three initial P2 findings fixed before the original PR was published.codex review --base origin/main; both reproduced P2 findings fixed (error-body read failures and native RetryInfo cooldowns).codex review --uncommittedreproduced an HTTP/2 cancellation-cause regression; fixed at the transport-body boundary with a cross-protocol regression and 3 compiled-proxy HTTP/2 checks.codex review --uncommitted: no actionable regressions. The reviewer also passed full tests, race tests, 32-bit tests, vet, and diff checks.Verification
go test -race -p 1 ./... -count=1GOARCH=386 go test ./...(final Codex review)go vet ./...make release-test(9 tests)gofmt.