fix(server): strip stack traces from error responses#154
Closed
ch1lam wants to merge 8 commits into
Closed
Conversation
docs: correct OpenCode repository URL in README files
…-qrcode docs: update community group chat QR code
The error handler returned err.stack to the client for unhandled exceptions, leaking internal file paths, dependency versions, and code structure. Use err.message instead — the stack trace is still logged server-side for debugging.
97aefc0 to
ab53d06
Compare
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
err.messageinstead oferr.stackin the server error handlerMotivation
The error handler in
packages/opencode/src/server/middleware.tsreturnederr.stackto the client for unhandled exceptions. Stack traces reveal internal implementation details that aid attackers in reconnaissance.Changes
The stack trace is still logged server-side via
log.error()for debugging purposes.Fixes #152