Skip to content

fix: add nil checks to prevent nil pointer dereferences #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sevico wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add nil checks to prevent nil pointer dereferences #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/direct_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,9 @@ func (dc *DirectConnection) writeAuthSwitchPacket(scrPasswd []byte) error {
// Caching sha2 authentication. Public key request and send encrypted password
func (dc *DirectConnection) writePublicKeyAuthPacketSha256(authData []byte, scramble []byte) error {
block, _ := pem.Decode(authData)
if block == nil {
return fmt.Errorf("failed to decode PEM block from auth data")
}
pub, err := x509.ParsePKIXPublicKey(block.Bytes)
if err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions backend/pooled_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ func (pc *pooledConnectImpl) WriteSetStatement() error {
func (pc *pooledConnectImpl) GetConnectionID() int64 {
if pc.directConnection.conn == nil {
log.Warn("GetConnectionID failed conn is nil, conn closed = %v, pc address = %v", pc.directConnection.IsClosed(), &(pc.directConnection))
return 0
}
return int64(pc.directConnection.conn.ConnectionID)
}
Expand Down