fix(config): add addon icon to DragonLoot Options TOC - #191
Conversation
The Options addon showed the default AddOns-list icon because its TOC had no IconTexture directive. Point it at the core addon's icon, which is guaranteed present via the declared DragonLoot dependency. Closes #189
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe DragonLoot Options table of contents now declares the DragonLoot addon icon texture. Other metadata, dependencies, and file listings remain unchanged. ChangesAddon icon metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to DragonLoot Options now declares the DragonLoot icon for display in the addon manager. The change is limited to metadata and presents no current merge-blocking risk. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
DragonLoot_Options/DragonLoot_Options.tochad no## IconTexture:directive, so the load-on-demand Options addon showed the default AddOns-list icon instead of the DragonLoot icon. The defect is cosmetic only: no code path, setting, or saved variable is affected.The fix adds one line:
It points at the core addon's icon, which is guaranteed present because the Options TOC already declares
## Dependencies: DragonLoot. The path matches the value the coreDragonLoot.tocalready uses.Verification
Limits, stated honestly:
just fmt-checkfailures are pre-existing and unrelated. The local Lua 5.1 toolchain is broken, so the busted suite could not run. Neither tool reads TOC metadata, so neither would cover this change.Closes #189
Summary by CodeRabbit