Skip to content

fix(config): add addon icon to DragonLoot Options TOC - #191

Merged
Xerrion merged 1 commit into
masterfrom
fix/189-options-addon-icon
Sep 5, 2026
Merged

fix(config): add addon icon to DragonLoot Options TOC#191
Xerrion merged 1 commit into
masterfrom
fix/189-options-addon-icon

Conversation

@Xerrion

@Xerrion Xerrion commented Sep 5, 2026

Copy link
Copy Markdown
Owner

What changed

DragonLoot_Options/DragonLoot_Options.toc had no ## IconTexture: directive, so the load-on-demand Options addon showed the default AddOns-list icon instead of the DragonLoot icon. The defect is cosmetic only: no code path, setting, or saved variable is affected.

The fix adds one line:

## IconTexture: Interface\AddOns\DragonLoot\DragonLoot_Icon

It points at the core addon's icon, which is guaranteed present because the Options TOC already declares ## Dependencies: DragonLoot. The path matches the value the core DragonLoot.toc already uses.

Verification

  • Confirmed the icon file exists in the packaged core addon layout, and that the path string matches the core TOC value exactly.
  • Confirmed the change is a single added metadata line with no Lua or load-order impact.

Limits, stated honestly:

  • The game client renders TOC metadata, so the icon cannot be confirmed outside the game. In-game confirmation on TBC Anniversary is still open.
  • Local just fmt-check failures are pre-existing and unrelated. The local Lua 5.1 toolchain is broken, so the busted suite could not run. Neither tool reads TOC metadata, so neither would cover this change.

Closes #189

Summary by CodeRabbit

  • New Features
    • Added an icon for the DragonLoot options interface, making it easier to identify visually.

The Options addon showed the default AddOns-list icon because its TOC
had no IconTexture directive. Point it at the core addon's icon, which
is guaranteed present via the declared DragonLoot dependency.

Closes #189
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: f5b29760-9e67-4dfe-bf1e-9cfcdb171d16

📥 Commits

Reviewing files that changed from the base of the PR and between c3eff16 and da7141d.

📒 Files selected for processing (1)
  • DragonLoot_Options/DragonLoot_Options.toc

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The DragonLoot Options table of contents now declares the DragonLoot addon icon texture. Other metadata, dependencies, and file listings remain unchanged.

Changes

Addon icon metadata

Layer / File(s) Summary
Declare addon icon texture
DragonLoot_Options/DragonLoot_Options.toc
Adds ## IconTexture: Interface\AddOns\DragonLoot\DragonLoot_Icon to the addon metadata.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to da714

DragonLoot Options now declares the DragonLoot icon for display in the addon manager. The change is limited to metadata and presents no current merge-blocking risk.

Suggested labels: options

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the required Conventional Commit format, fix(config): description, and accurately describes the TOC icon change.
Linked Issues check ✅ Passed The change adds the ## IconTexture directive required to display the DragonLoot icon for the Options sub-addon, satisfying issue #189.
Out of Scope Changes check ✅ Passed The pull request contains only the TOC metadata change needed for issue #189. No unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the options label Sep 5, 2026
@Xerrion
Xerrion merged commit 3a208b0 into master Sep 5, 2026
3 checks passed
@Xerrion
Xerrion deleted the fix/189-options-addon-icon branch September 5, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Addon Icon in TBC Anniversary

1 participant