Repository navigation
Delete the unused Aloha tactile policy - #17
Conversation
`aloha_tactile_policy` has no importers — the only policy module in the package with none (`aloha_policy`, its non-tactile sibling, is reached through `LeRobotAlohaDataConfig`). It was never YAML-reachable either: the transform registry admits `RepackTransform` and nothing else, so no config could name `AlohaTactileInputs` even deliberately. Worth stating what this leaves behind: `Pi0TactileConfig` stays in the model registry, and this was the only shipped transform producing the `<arm>_tactile_<finger>_rgb` slots it consumes. Anyone reaching for Pi0Tactile now has to write that transform. The model path is otherwise untouched. pytest src/openpi/training src/openpi/policies examples -> 138 passed, unchanged from before the delete. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
90708e2 to
541cc1c
Compare
|
Reviewed against upstream
The "what this leaves behind" note is also correct: One thing the description assumes that does not holdIt treats Pi0Tactile as a working model left without a data path. It is not working. class Pi0Tactile(nnx.Module):—
That path is reachable: And So deleting this transform costs Pi0Tactile nothing it could have used. That strengthens the case for this PR rather than weakening it — but it means the follow-up is a deletion, not a transform someone still needs to write. Also worth knowing
LGTM. |
src/openpi/policies/aloha_tactile_policy.pyis dead code. Verified rather than assumed:aloha_policy, its non-tactile sibling, is reached throughLeRobotAlohaDataConfig.registry.TRANSFORMSadmitsRepackTransformand nothing else, so no config could nameAlohaTactileInputseven on purpose.configs/is the XTac-UMI one, which runsxtac_umi_policyand does not consume tactile streams.What this leaves behind
Pi0TactileConfigstays in the model registry, and this was the only shipped transform producing the<arm>_tactile_<finger>_rgbslots it consumes. So Pi0Tactile is now a registered model with no shipped data path — anyone reaching for it has to write that transform themselves.models/pi0_tactile.py,pi0_tactile_config.pyandIMAGE_KEYS_TACTILEare otherwise untouched.If that whole path is dead too, removing it is a bigger and separate call — flagging it rather than folding it in here.
Verification
ruff check src/ examples/cleanpytest src/openpi/training src/openpi/policies examples→ 138 passed, identical to before the delete; the one failure (policy_rtc_test) reproduces on a clean tree and predates this branchopenpi.training.configandopenpi.policies.policy_configimport clean🤖 Generated with Claude Code