Add github actions for packer build#96
Open
phillebaba wants to merge 8 commits into
Open
Conversation
nissessenap
suggested changes
Nov 4, 2021
nissessenap
left a comment
nissessenap
left a comment
Contributor
There was a problem hiding this comment.
Some thoughts but as always I think it looks good.
| required: false | ||
| default: '["ubuntu-latest"]' | ||
| ENVIRONMENTS: | ||
| description: '{"environments":[{"name":"dev"}, {"name":"qa"}]}' |
Contributor
There was a problem hiding this comment.
Do we really need this building packer images? Isn't it enough with one time?
| type: string | ||
| IMAGE: | ||
| description: "Image to build Packer with" | ||
| required: true |
Contributor
There was a problem hiding this comment.
Github workflow is funny, even if you define "default" and add "required" it will still force the user to define the image. So you have to set required: false :(
| required: true | ||
| type: string | ||
| PACKER_TEMPLATE_REPO_BRANCH: | ||
| description: "Branch to the packer template from" |
Contributor
There was a problem hiding this comment.
We shouldn't default to main?
| ENV: ${{ matrix.environments.name }} | ||
| TMP_DIR: ${{ runner.temp }} | ||
| IMAGE: ${{ inputs.IMAGE }} | ||
| RESOURCE_GROUP: "rg-${{ matrix.environments.name }}-we-${{ inputs.RESOURCE_GROUP_NAME_SUFFIX }}" |
Contributor
There was a problem hiding this comment.
I don't think that we always can assume that we are in region we I would add this as a variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.