fix 115#22
Closed
Jassicia wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to add an MLU implementation for problem 115 (Unfold / im2col) and updates the root config so the evaluation system runs that problem.
Changes:
- Add
Unfold.mluimplementing a half-precisionunfold_kerneland abang_funcwrapper producing[N, C*K*K, H_out*W_out]. - Update
configto evaluate problem115instead of075.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Unfold.mlu | Adds Unfold/im2col kernel and bang_func wrapper for task 115. |
| config | Switches evaluation target to problem 115. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+78
to
+83
| int H_out = (H + 2 * padding - K) / stride + 1; | ||
| int W_out = (W + 2 * padding - K) / stride + 1; | ||
|
|
||
| TORCH_CHECK(H_out > 0 && W_out > 0, | ||
| "Invalid output size: H_out=", H_out, ", W_out=", W_out); | ||
|
|
Comment on lines
+84
to
+88
| int rows = C * K * K; | ||
| int columns = H_out * W_out; | ||
| int total = N * rows * columns; | ||
|
|
||
| auto output = torch::empty({N, rows, columns}, x.options()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix 115