Skip to content

Fix active effect interactions on items and characters - #325

Merged
ClipplerBlood merged 1 commit into
Xacus:masterfrom
Ykabrit:master
Sep 2, 2026
Merged

Fix active effect interactions on items and characters#325
ClipplerBlood merged 1 commit into
Xacus:masterfrom
Ykabrit:master

Conversation

@Ykabrit

@Ykabrit Ykabrit commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
  1. Passive Active Effects failed to create on Characters because of Infinite duration. Now null.
  2. No interactions were possible with Active Effects on items (create, edit, delete, toggle). onManageEffect in base-item-sheet.js passed an html item instead of the event to onManageActiveEffect from effects.js, and there was a mismatch on the values of the data-action property in the item-effects.hbs template: create expected instead of createEffect.*

*I didn't change the values in the Handlebars template because it broke the event handling for some reason, so I just added createEffect, editEffect, etc. as also valid values in the onManageActiveEffects handler.

@ClipplerBlood
ClipplerBlood merged commit a601fc4 into Xacus:master Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants