AzureServiceBusHealthCheck chooses the connection method based on the connection string being present#2397
Open
tj-spyro wants to merge 2 commits into
Open
Conversation
…d defaults to DefaultAzureCredential for authentication in with namespace if not set
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DefaultAzureCredentialwhen a credential is not provided.*WithNamespace()extension methods for registering using theDefaultAzureCredentialand minimal configuration of the queue/topic/subscription when using a fully qualified namespace.This aligns with the direction and behaviour the dotnet Aspire Team take for which options take precedence and default values.
Which issue(s) this PR fixes:
#2395
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?:
This would not break existing users configuration.
Please make sure you've completed the relevant tasks for this PR, out of the following list: