Skip to content

AzureServiceBusHealthCheck chooses the connection method based on the connection string being present#2397

Open
tj-spyro wants to merge 2 commits into
Xabaril:masterfrom
tj-spyro:service-bus-connection-options
Open

AzureServiceBusHealthCheck chooses the connection method based on the connection string being present#2397
tj-spyro wants to merge 2 commits into
Xabaril:masterfrom
tj-spyro:service-bus-connection-options

Conversation

@tj-spyro

@tj-spyro tj-spyro commented Jul 25, 2025

Copy link
Copy Markdown

What this PR does / why we need it:

  • Using the connection string for Azure Service Bus is now based on it being not null or empty, instead of a credential being not null.
  • Azure Service Bus health checks default to using the DefaultAzureCredential when a credential is not provided.
  • Adds simple *WithNamespace() extension methods for registering using the DefaultAzureCredential and minimal configuration of the queue/topic/subscription when using a fully qualified namespace.

This aligns with the direction and behaviour the dotnet Aspire Team take for which options take precedence and default values.

Which issue(s) this PR fixes:
#2395

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:
This would not break existing users configuration.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

tj-spyro added 2 commits July 25, 2025 17:31
…d defaults to DefaultAzureCredential for authentication in with namespace if not set
@tj-spyro

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant