Fix button number labels in custom action descriptions and logic bug in button 4 double press - #19
Open
skille wants to merge 3 commits into
Open
Fix button number labels in custom action descriptions and logic bug in button 4 double press#19skille wants to merge 3 commits into
skille wants to merge 3 commits into
Conversation
… 2 and 4 Buttons 1, 2, and 4 had copy-paste errors in their custom action section input descriptions — all incorrectly referenced "Button 3". No logic changes, descriptions only. Fixes XXBrain#18
…m action Cosmetic: Custom action section descriptions for buttons 1, 2 and 4 incorrectly referenced "Button 3" due to copy-paste errors. Logic bug: Button 4 double_press custom action variable was reading `button_3_double_custom` instead of `button_4_double_custom` (line 1170), causing button 4 double press custom actions to silently run button 3's custom action instead. Fixes XXBrain#18
There was a problem hiding this comment.
Pull request overview
This PR updates the Home Assistant blueprint philips_zigbee_dial_combined_z2m.yaml to correct mislabeled custom-action input descriptions (buttons 1, 2, and 4) and fixes a logic error where Button 4 double-press actions were incorrectly mapped to Button 3’s custom action.
Changes:
- Corrects copy/paste label text in the blueprint input descriptions for Button 1, Button 2, and Button 4 custom actions.
- Fixes the
actions_custom.double_press.button_4mapping to reference!input button_4_double_custom(instead ofbutton_3_double_custom). - Adds an extra trailing blank line at the end of the YAML file.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Changes
Cosmetic (descriptions only)
The custom action input descriptions for buttons 1, 2, and 4 all incorrectly referenced "Button 3" — a copy-paste error. No logic was affected.
Action to run on a release of Button 3 after a short pressAction to run when Button 3 is released after a long pressname: Button 3 (Double Press)Action to run when Button 3 is pressed twiceAction to run when Button 3 is released after a short pressAction to run when Button 3 is released after a long pressname: Button 3 (Double Press)Action to run when Button 3 is pressed twiceAction to run on a release of Button 3 after a short pressAction to run when Button 3 is released after a long pressname: Button 3 (Double Press)Action to run when Button 3 is pressed twiceLogic bug (line 1170)
Button 4's double press custom action variable referenced
button_3_double_custominstead ofbutton_4_double_custom. This caused button 4 double press custom actions to silently execute button 3's custom action instead.